[BUGFIX release] isUpdating flag is set correctly for store.findAll
#4386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A regression for the `isUpdating` flag on the RecordArray returned for `store.peekAll` has been introduced in #4316: the flag isn't set to true anymore when records are reloaded or a background reloaded.
|
Thanks @pangratz. |
|
Does this fix only Does this fix #4376 as well? Edit: Nevermind, I mixed up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression for the
isUpdatingflag on the RecordArray returned forstore.peekAllhas been introduced in #4316: the flag isn't set to trueanymore when records are reloaded or a background reloaded.
This closes #4339.