Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isReloading when a record is reloaded in the background #4376

Closed
felixkiss opened this issue May 9, 2016 · 3 comments
Closed

Update isReloading when a record is reloaded in the background #4376

felixkiss opened this issue May 9, 2016 · 3 comments

Comments

@felixkiss
Copy link

As discussed with @bmac on Slack:

Currently, neither record.isLoading nor record.isReloading is set to true while the adapter performs a background reload of the specific record.

At least isReloading should be true during the time the adapter waits for a server response.

@pete-the-pete
Copy link
Contributor

@runspired after a quick and random look through the code, it seems that reload has some pretty specific meaning...the app is explicitly calling reload on the model or relationship. Does it make sense to have a new property to signify backgroundReloading specifically?

Also, the comments at data/addon/-private/system/model/states.js are pretty helpful, sad I missed the before

@runspired
Copy link
Contributor

We believe the request state RFC provides infrastructure necessary for an add-on or app to expose a flag for whether a record has any pending requests (not just a primary reload or a background reload).

@ghost
Copy link

ghost commented Feb 12, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants