Cleanup record array manager #4597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
force-pushed
the
cleanup-record-array-manager
branch
5 times, most recently
from
f3228b7
to
db29f12
Compare
pangratz
reviewed
Oct 21, 2016
|
|
||
| test('stores the metadata off the payload', function(assert) { | ||
| let recordArray = store.recordArrayManager | ||
| .createAdapterPopulatedRecordArray(store.modelFor('person'), null); |
There was a problem hiding this comment.
We can re-use Person like we do 2 tests below.
|
|
||
| assert.throws(() => { | ||
| recordArray.replace(); | ||
| }, Error('The result of a server query (on (subclass of DS.Model)) is immutable.'), 'throws error'); |
There was a problem hiding this comment.
We're overwriting toString() in the Person above. Not sure why it's used here though.
There was a problem hiding this comment.
I would expect the assertion to be 'The result of a server query (on Person) is immutable.'.
There was a problem hiding this comment.
opened issue: #4615
| function assertRecordHasRecordArray(assert, record, recordArray) { | ||
| if (!assert) { throw TypeError('assertRecordHasRecordArray first argument must be QUnit\'s assert'); } | ||
| if (!record) { throw TypeError('assertRecordHasRecordArray second argument must be a record'); } | ||
| if (!assert) { throw TypeError('assertRecordHasRecordArray third argument must be a recordArray'); } |
| function assertRecordDoesNOTRecordArray(assert, record, recordArray) { | ||
| if (!assert) { throw TypeError('assertRecordHasRecordArray first argument must be QUnit\'s assert'); } | ||
| if (!record) { throw TypeError('assertRecordHasRecordArray second argument must be a record'); } | ||
| if (!assert) { throw TypeError('assertRecordHasRecordArray third argument must be a recordArray'); } |
igorT
reviewed
Oct 21, 2016
| @@ -73,15 +76,19 @@ export default RecordArray.extend({ | |||
| */ | |||
| loadRecords(internalModels, payload) { | |||
| let token = heimdall.start('AdapterPopulatedRecordArray.loadRecords'); | |||
|
|
|||
| // TODO: initial load should not cause change events at all, only | |||
| let token = heimdall.start('AdapterPopulatedRecordArray.loadRecords'); | ||
| _setInternalModels(internalModels, payload) { | ||
| let token = heimdall.start('AdapterPopulatedRecordArray._setInternalModels'); | ||
| let operations = {}; |
stefanpenner
force-pushed
the
cleanup-record-array-manager
branch
from
1af7268
to
dacfb9d
Compare
* make adding/removing from recordArrays private * make recordArray add/remove support batches * rename addInternalModel -> _pushInternalModels to be more accurate (push not add, and plural)) * [PERF] don’t use addObject in recordArrays, as the RecordArrayManager via internalRecord._recordArrays already checks containment, no need in duplicating that work by re-scanning addObject for each record added to the recordArray. * add tests, covering the duplication behavior * add comments, to ensure we don’t accidentally go back to pushObject
* cleanup code * move non-unit tests to integration folder
…uring loadRecords Replace the values contained within content, rather then replacing content. Without this we: * signal `content` changed (no point) * signal strange array mutations on the ArrayProxy (from empty content, instead of previous content); Backfill missing tests
* make the very private method more private \w underscore * rename loadRecords to _setInternalModels
stefanpenner
force-pushed
the
cleanup-record-array-manager
branch
from
dacfb9d
to
b699683
Compare
|
updated re: @igorT feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to improving duplicate work:
internalModel._recordArraysensure we remove adapterPopulatedRecordArrays when removing an internalModel from themloadRecordsto a more private and correctly named_setInternalModels