Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup record array manager #4597

Merged
merged 5 commits into from
Oct 22, 2016
Merged

Cleanup record array manager #4597

merged 5 commits into from
Oct 22, 2016

Commits on Oct 22, 2016

  1. [PERF pt.1] avoid extra scanning of recordArrays when adding records 

    * make adding/removing from recordArrays private
* make recordArray add/remove support batches
* rename addInternalModel -> _pushInternalModels to be more accurate (push not add, and plural))
* [PERF] don’t use addObject in recordArrays, as the RecordArrayManager via internalRecord._recordArrays already checks containment, no need in duplicating that work by re-scanning addObject for each record added to the recordArray.
* add tests, covering the duplication behavior
* add comments, to ensure we don’t accidentally go back to pushObject
    @stefanpenner
    stefanpenner committed Oct 22, 2016
    Configuration menu
    Copy the full SHA
    890d051 View commit details
    Browse the repository at this point in the history

  2. tidy up tests related to adapter-populated-record-arrays 

    * cleanup code
* move non-unit tests to integration folder
    @stefanpenner
    stefanpenner committed Oct 22, 2016
    Configuration menu
    Copy the full SHA
    f5c2ba5 View commit details
    Browse the repository at this point in the history

  3. tidy up proxy related change events for AdapterPopulatedRecordArray d… 

    …uring loadRecords

Replace the values contained within content, rather then replacing content. Without this we:

* signal `content` changed (no point)
* signal strange array mutations on the ArrayProxy (from empty content, instead of previous content);

Backfill missing tests
    @stefanpenner
    stefanpenner committed Oct 22, 2016
    Configuration menu
    Copy the full SHA
    b5785fe View commit details
    Browse the repository at this point in the history

  4. tidy-up AdapterPopulatedRecordArrays: 

    * make the very private method more private \w underscore
* rename loadRecords to _setInternalModels
    @stefanpenner
    stefanpenner committed Oct 22, 2016
    Configuration menu
    Copy the full SHA
    e5f106e View commit details
    Browse the repository at this point in the history

  5. fixup based on PR review

    @stefanpenner
    stefanpenner committed Oct 22, 2016
    Configuration menu
    Copy the full SHA
    b699683 View commit details
    Browse the repository at this point in the history