fix(benchmarks): benchmarks for store.query no longer included record… #4696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmac
reviewed
Dec 6, 2016
| @@ -24,6 +24,7 @@ export default Route.extend({ | |||
| let token = heimdall.start('ember-data'); | |||
| return this.get('store').query(modelName, params) | |||
| .then((records) => { | |||
| records.toArray(); | |||
There was a problem hiding this comment.
@runspired do you mind adding a comment explaining this line forces the materialization so we don't forget in the future?
… materialization as this is now so lazy that it must be forced, this makes the benchmark force it so that we can continue to measure improvement within materialization
…ecordArray returned by store.query
runspired
force-pushed
the
bench/query-materialization
branch
from
12de6dc
to
7bf3805
Compare
|
@bmac updated and rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… materialization as this is now so lazy that it must be forced, this makes the benchmark force it so that we can continue to measure improvement within materialization