Update deprecate arguments #4760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to docs (https://github.com/emberjs/ember.js/blob/v2.10.0/packages/ember-debug/lib/deprecate.js#L97) ember deprecate requires 3 arguments.
rwjblue
requested changes
Jan 18, 2017
| @@ -1783,7 +1783,7 @@ Store = Service.extend({ | |||
| @return {boolean} | |||
| */ | |||
| recordIsLoaded(modelName, id) { | |||
| deprecate(`Use of recordIsLoaded is deprecated, use hasRecordForId instead.`, { | |||
| deprecate(`Use of recordIsLoaded is deprecated, use hasRecordForId instead.`, true, { | |||
There was a problem hiding this comment.
This should be false not true. These deprecations (AFAICT) are never being triggered.
deprecate('foo', true, { id: 'asdf', until: 'asdf'}) doesn't actually deprecate anything, but deprecate('foo', false, { id: 'asdf', until: 'asdf'}) does.
There was a problem hiding this comment.
@rwjblue That's correct.
rwjblue
approved these changes
Jan 19, 2017
|
Thanks @estshy. |
bmac
pushed a commit
that referenced
this pull request
Feb 3, 2017
* Update deprecate arguments According to docs (https://github.com/emberjs/ember.js/blob/v2.10.0/packages/ember-debug/lib/deprecate.js#L97) ember deprecate requires 3 arguments. * Update store.js (cherry picked from commit 0c26d2d)
bmac
pushed a commit
that referenced
this pull request
Feb 3, 2017
* Update deprecate arguments According to docs (https://github.com/emberjs/ember.js/blob/v2.10.0/packages/ember-debug/lib/deprecate.js#L97) ember deprecate requires 3 arguments. * Update store.js (cherry picked from commit 0c26d2d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to docs (https://github.com/emberjs/ember.js/blob/v2.10.0/packages/ember-debug/lib/deprecate.js#L97) ember deprecate requires 3 arguments.