Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC release] Add missing docs for preload option. #4769

Merged
merged 1 commit into from Jan 25, 2017
Merged

[DOC release] Add missing docs for preload option. #4769

merged 1 commit into from Jan 25, 2017

Conversation

GCheung55
Copy link

No description provided.

locks
locks reviewed Jan 25, 2017
View reviewed changes
addon/-private/system/store.js

```javascript
store.findRecord('post', 1).then(function (myPostModel) {
store.findRecord('comment', 2, {post: myPostModel});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put some spaces inside the {} like in the first code block?

Copy link
Author

@GCheung55 GCheung55 Jan 25, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@locks Done and done, I squashed the commits.

@bmac bmac merged commit 440cae6 into emberjs:master Jan 25, 2017
@bmac
Copy link
Member

bmac commented Jan 25, 2017

Thanks @GCheung55.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locks locks locks left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GCheung55 @bmac @locks