Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loose es6 class #4864

Merged
merged 1 commit into from
Mar 16, 2017
Merged

Loose es6 class #4864

merged 1 commit into from
Mar 16, 2017

Conversation

stefanpenner
Copy link
Member

@stefanpenner stefanpenner commented Mar 15, 2017

make ES6.Classes loose

  • makes profiling easier (methods are not called value)
  • appears to be a slight performance improvement (although not the motivator)

* makes profiling easier (methods are not called value)
* appears to be a slight performance improvement (although not the motivator)
@stefanpenner
Copy link
Member Author

should we consider bugfix beta?

@stefanpenner stefanpenner requested a review from bmac March 15, 2017 17:33
@rwjblue
Copy link
Member

rwjblue commented Mar 15, 2017

@stefanpenner - #4862 plans to land into beta. I've updated to use loose mode there also, and hope to land that PR today. Any objections to closing this in favor of that? I don't really mind either way, just pointing out what I'm working on...

@stefanpenner
Copy link
Member Author

@rwjblue lets use your PR (if its landed in the next few days). We should keep this around, in-case @bmac thinks its appropriate for a bugfix beta.

@rwjblue
Copy link
Member

rwjblue commented Mar 15, 2017

@stefanpenner - Seems good. #4862 is ready for review, and also intends to target beta branch.

@rwjblue rwjblue mentioned this pull request Mar 15, 2017
@stefanpenner stefanpenner merged commit bf2be7f into master Mar 16, 2017
@stefanpenner stefanpenner deleted the loose-es6-class branch March 16, 2017 01:07
@stefanpenner
Copy link
Member Author

#4862 will still supercede, this will simplify my until then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants