Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename record[s] -> internalModel[s] #4874

Merged
merged 2 commits into from
Apr 4, 2017
Merged

Rename record[s] -> internalModel[s] #4874

merged 2 commits into from
Apr 4, 2017

Conversation

hjdivad
Copy link
Member

@hjdivad hjdivad commented Mar 16, 2017

Within relationships/state/* and many-array (as well as call sites).

Please note this is downstream of #4821 so do not merge (or even expect the diff to be easy to read) until #4821 lands.

@hjdivad
Copy link
Member Author

hjdivad commented Mar 16, 2017

https://github.com/emberjs/data/pull/4874/files/97dd39dff934d951ff761b561ae7d6d628cf2d73..71821b6fd46fa1526c040c8912def7d9f3fd2f8e to see the diff before #4821 lands

@hjdivad hjdivad force-pushed the hjdivad/cleanup-names-relationships branch from 71821b6 to 2c5ac1d Compare March 21, 2017 17:32
@hjdivad hjdivad requested a review from igorT March 21, 2017 18:11
@bmac
Copy link
Member

bmac commented Mar 31, 2017

This looks good to me @hjdivad 👍. Would you mind rebasing the pr and squashing the commits?

@hjdivad
Rename record -> internalModel
8dd33bc 
Within relationships state, which now deals almost exclusively with
internal models.
@hjdivad
Rename record -> internalModel
5d79ed4 
Within many-array which mostly deals with internal models.
@hjdivad hjdivad force-pushed the hjdivad/cleanup-names-relationships branch from 2c5ac1d to 5d79ed4 Compare April 4, 2017 18:25
@hjdivad
Copy link
Member Author

hjdivad commented Apr 4, 2017

@bmac rebased

@hjdivad
Copy link
Member Author

hjdivad commented Apr 4, 2017

test failure is unrelated

@stefanpenner stefanpenner merged commit b03427f into master Apr 4, 2017
@stefanpenner stefanpenner deleted the hjdivad/cleanup-names-relationships branch April 4, 2017 21:06
@stefanpenner
Copy link
Member

test failure was 1 of the travis runs but the other (identical run) completed without issue..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmac bmac bmac approved these changes

@igorT igorT Awaiting requested review from igorT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hjdivad @bmac @stefanpenner