[SVELTE] Transforms & remove Date.parse polyfill #4936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
changed the title
|
I like the idea, #4925 is waiting for you though. Lets get that one in, so we can look at this one (diff is rather large until that one lands). |
runspired
force-pushed
the
svelte/cleanup-transforms
branch
from
74aef8a
to
ca15b82
Compare
stefanpenner
suggested changes
Apr 25, 2017
| @@ -39,28 +38,22 @@ test('#deserialize', function(assert) { | |||
| assert.equal(transform.deserialize(undefined), null); | |||
| }); | |||
|
|
|||
| test('#deserialize with different offset formats', function(assert) { | |||
| testInDebug('#deserialize with different offset formats', function(assert) { | |||
There was a problem hiding this comment.
I think we should likely always test this, but only test the expect deprecation in debug.
There was a problem hiding this comment.
I agree, but I'm not sure (based on how that stripping happens) how to set this up at a glance. I will think.
runspired
force-pushed
the
svelte/cleanup-transforms
branch
from
8af2bc1
to
0717f70
Compare
stefanpenner
approved these changes
Apr 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR branches off ofLanded :)svelte/rollup-privateand will need that to land first, the relevant commit is 89f4c9dThis PR brings Transforms back into the public folder (they had moved into the Private folder during the first phase of rollup).
The motivation for the original move was due to the location of initializers (later fixed in that PR) as well as the private
Date.parsepolyfill.In addition to bringing these back into the public folder, this removes the
Date.parsepolyfill as much as possible, adding a new deprecation for a corner case which our polyfill handled but which is not part of the spec.Removing the
Date.parsepolyfill has been debated before, here's a short TL;DROur custom Date parsing logic pre-dated and polyfilled the ES5 behavior; however, we now only support ES5 browsers.
In ES2015, initially there was a breaking change which prevented us from removing our custom parsing logic, however, that breaking change was reverted and not implemented by major browsers. We can now safely rely on the native
Date.parse.Previous discussions of our own here: #2685
See: tc39/ecma262#138
and: tc39/ecma262#87
However, it turns our the polyfill we are using does not conform to the ECMA variant of ISO 8601, with a minor difference in that it allows for a "shorthand" timezone offset which is part of the greater spec but not ECMA.
This means that going immediately to the native
Date.parseis not possible without a deprecation, which has been detected and added here: 74aef8a#diff-6da4887e7f026f285304a8bbb0f06e68R64