Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Update dependencies to use Babel 6. #4937

Merged
merged 1 commit into from Apr 23, 2017

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Apr 22, 2017

In ember-cli@2.13 we intend to ship only one version of babel by default (though having multiple versions does work perfectly fine).

These deps have just been released, the only breaking change (to them) was bumping the min engine version to Node 4 which we have already done here.

@bmac - Is it possible to land this into 2.13.0 before shipping it?

@bmac
Copy link
Member

bmac commented Apr 22, 2017

Looks like there are some dependency errors in the build but we should be able to fix those and get this merged in before the 2.13 release.

In ember-cli@2.13 we intend to ship only one version of babel by default
(though having multiple versions does work perfectly fine).

These deps have just been released, the only breaking change (to them)
was bumping the min engine version to Node 4 which we have already done
here.
@rwjblue
Copy link
Member Author

rwjblue commented Apr 22, 2017

I tweaked the peerDependencies entry for ember-inflector. That should fix at least one of the issues that Travis had...

@rwjblue
Copy link
Member Author

rwjblue commented Apr 23, 2017

Sweet, looks like that was the issue.

@bmac - Passing now.

@bmac bmac merged commit 18360bc into emberjs:master Apr 23, 2017
@bmac
Copy link
Member

bmac commented Apr 23, 2017

Thanks @rwjblue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants