[BUGFIX BETA] Added system/store/container-instance-cache to the -private export

[workmanw]

I'm sure adding more things to the -private export is 😢 . Unfortunately we need access to this class in ember-data-model-fragments. There was previously a discussion about alternative approaches, but we settled on monkey patching this class (adopted-ember-addons/ember-data-model-fragments#224).

[stefanpenner]

@workmanw can you add a test, so we can be sure to not regress?

[workmanw]

@stefanpenner Added. There wasn't really presidence for this, and short of writing some tests that touch the interface of this, I didn't know what more to test than assert.ok(!!ContainerInstanceCache). Certainly open to feedback here.

I also added two more tests for InstanceModel and RootStates, both consumed by ember-data-model-fragments.

[stefanpenner]

@workmanw awesome thanks. One last request, if you can leave a comment as to who is depending on this private API. It wont be a mystery for future travelers.

[workmanw]

@stefanpenner Good idea. Would you prefer to see it in the -private/index.js file or the tests?

[stefanpenner]

@stefanpenner Good idea. Would you prefer to see it in the -private/index.js file or the tests?

file

[workmanw]

👍 Done. Thank you.

[bmac]

Thanks @workmanw.

[workmanw]

Thanks @bmac! Any chance I could talk you into cherry-picking this into the beta branch sometime in the next few days? That way I can get the model-fragments beta tests working for the next release.

[bmac]

@workmanw I just published v2.14.0-beta.3.

[workmanw]

@bmac Thank you!!!