[BUGFIX release] createRecord should only setup relationships it has … #5048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
force-pushed
the
only-setup-relationships-with-data
branch
2 times, most recently
from
c6485ee
to
d52c3e8
Compare
hjdivad
approved these changes
Jul 3, 2017
| let book = store.createRecord('book', { name: 'The Greatest Book' }); | ||
| let relationship = book._internalModel._relationships.get('author'); | ||
|
|
||
| assert.equal(relationship.hasData, false, 'relationship has data'); |
There was a problem hiding this comment.
assertion message is wrong: relationship does not have data
| }); | ||
|
|
||
| let relationship = book._internalModel._relationships.get('author'); | ||
| assert.equal(relationship.hasData, false, 'relationship has data'); |
| let page = store.createRecord('page'); | ||
|
|
||
| let relationship = chapter._internalModel._relationships.get('pages'); | ||
| assert.equal(relationship.hasData, false, 'relationship has data'); |
| let chapter = store.createRecord('chapter', { title: 'The Story Begins' }); | ||
| let relationship = chapter._internalModel._relationships.get('pages'); | ||
|
|
||
| assert.equal(relationship.hasData, false, 'relationship has data'); |
hjdivad
force-pushed
the
only-setup-relationships-with-data
branch
from
d7280b8
to
db42a28
Compare
stefanpenner
force-pushed
the
only-setup-relationships-with-data
branch
from
db42a28
to
f741f34
Compare
stefanpenner
force-pushed
the
only-setup-relationships-with-data
branch
from
f741f34
to
8628f2a
Compare
|
did a rebase now, seems to be blocked by: SyntaxError: ember-data/adapters/json-api.js: @ember/debug does not have a deprecate import
7 | import RESTAdapter from "./rest";
8 | import { isEnabled } from '../-private';
> 9 | import { deprecate } from '@ember/debug';
| ^
10 | import { instrument } from 'ember-data/-debug';@rwjblue is investigating. |
stefanpenner
force-pushed
the
only-setup-relationships-with-data
branch
2 times, most recently
from
605fcae
to
8628f2a
Compare
|
@runspired r? |
|
LGTM |
|
@bmac got cycles for a backport + release? (I'm currently on vacation, but if you don't have cycles I can handle it) |
|
@stefanpenner I'm on it. |
|
Released as 2.14.4. |
|
@bmac awesome thanks dude, you rock! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…data for
relationships should in theory now only be accessed if they are used (
setorget). This should mitigate the large number of test failures see during upgrade due to todata/addon/-private/system/relationships/state/create.js
Line 20 in e6cb564
If this doesn't actually fix the issue in enough cases, we can always turn that assert into a warn or something. But I would love a failing test for the exact case that remains (if one exists) to be 100% sure. As I would prefer to not loose a good assertion unless we must.