[BUGFIX beta] Implement cacheKeyForTree hook.
#5110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hook was added in [ember-cli/rfcs#90](https://github.com/ember-cli/rfcs/blob/master/complete/0090-addon-tree-caching.md), and essentially guarantees that a given tree returned by an addon is considered stable (or not). In the case of Ember Data, we do not have different tree output based on our parent (project or addon). Specifically, this implementation allows both an app _and_ a lazy engine to depend on `ember-data` without duplicating the `ember-data` assets in both the `assets/vendor.js` and `engine-dist/<engine-name>/assets/engine-vendor.js`.
rwjblue
force-pushed
the
add-cache-key-for-tree
branch
from
89bdfc0
to
59bf5cb
Compare
|
Rebased. |
The bizarre failures on CI are related to the super old Yarn version in use on the Trusty arch (0.17.5), and seem to randomly fail based on which CI image a build runs on (super frustratingly :P ). This updates our Travis config to ensure the latest yarn is installed (and also updates the mechansim we use to get phantom so that it works across both Trusty and Precise images).
|
@rwjblue will this be released in 2.15? would it be possible to get this released as a part of 2.14? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hook was added in ember-cli/rfcs#90, and essentially guarantees that a given tree returned by an addon is considered stable (or not).
In the case of Ember Data, we do not have different tree output based on our parent (project or addon).
Specifically, this implementation allows both an app and a lazy engine to depend on
ember-datawithout duplicating theember-dataassets in both theassets/vendor.jsandengine-dist/<engine-name>/assets/engine-vendor.js.Fixes ember-engines/ember-engines#438.