[CLEANUP] PERF prevent duplicate recordArrayManager signals on push o… #5151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f a new record * if the record is new, ensure only 1 recordWasLoaded is called (after setup) * if the record is existing, ensure only 1 recordDidChange is called (after setup) * decouple InternalModel slightly more from recordArrayManager * remove now defunct code
stefanpenner
commented
Aug 25, 2017
| internalModel.setupData(data); | ||
|
|
||
| this.recordArrayManager.recordDidChange(internalModel); | ||
| if (isUpdate) { | ||
| this.recordArrayManager.recordDidChange(internalModel); |
There was a problem hiding this comment.
previously, when pushing a new record this was firing, even though a new record has no updates. It merely starts off its existence in that state...
This resulted in every new record going through the record-array manager twice on initial push...
|
If someone has issues with this due to a potential feature related issue, please provide a failing test, that way we can codify if we are missing something. |
rwjblue
approved these changes
Aug 29, 2017
stefanpenner
deleted the
reduce-duplicate-signals-to-record-array-manager-on-record-push
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…f a new record