[BUGFIX beta] Avoid cache related warnings during builds. #5196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broccoli-babel-transpiler (which we use by way of ember-cli-babel) requires that all plugins have a `.baseDir` function which broccoli-babel-transpiler uses to ensure that it can properly invalidate the cached output of each transpiled file. If `.baseDir` is not present broccoli-babel-transpiler does the only "safe" thing and completely opts out of this caching system and prints a very loud warning message. This commit ensures that the few custom plugins that we are using are properly setup with a `.baseDir`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
broccoli-babel-transpiler (which we use by way of ember-cli-babel) requires that all plugins have a
.baseDirfunction which broccoli-babel-transpiler uses to ensure that it can properly invalidate the cached output of each transpiled file. If.baseDiris not present broccoli-babel-transpiler does the only "safe" thing and completely opts out of this caching system and prints a very loud warning message.This commit ensures that the few custom plugins that we are using are properly setup with a
.baseDir.Fixes #5164