Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Avoid cache related warnings during builds. #5196

Merged
merged 1 commit into from Oct 1, 2017

Conversation

@rwjblue
Copy link
Member

commented Oct 1, 2017

broccoli-babel-transpiler (which we use by way of ember-cli-babel) requires that all plugins have a .baseDir function which broccoli-babel-transpiler uses to ensure that it can properly invalidate the cached output of each transpiled file. If .baseDir is not present broccoli-babel-transpiler does the only "safe" thing and completely opts out of this caching system and prints a very loud warning message.

This commit ensures that the few custom plugins that we are using are properly setup with a .baseDir.

Fixes #5164

broccoli-babel-transpiler (which we use by way of ember-cli-babel)
requires that all plugins have a `.baseDir` function which
broccoli-babel-transpiler uses to ensure that it can properly invalidate
the cached output of each transpiled file. If `.baseDir` is not present
broccoli-babel-transpiler does the only "safe" thing and completely opts
out of this caching system and prints a very loud warning message.

This commit ensures that the few custom plugins that we are using are
properly setup with a `.baseDir`.
@bmac bmac merged commit 533c6a5 into emberjs:master Oct 1, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rwjblue rwjblue deleted the rwjblue:avoid-caching-warnings branch May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.