[BUGFIX beta] Normalize model names during push
#5242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjdivad
force-pushed
the
hjdivad/store-normalized-model-name
branch
from
f8f6750
to
4f4db40
Compare
|
@bmac @fivetanley @runspired this is re the conversation we were having yesterday |
runspired
approved these changes
Oct 25, 2017
pangratz
approved these changes
Oct 25, 2017
rwjblue
approved these changes
Oct 25, 2017
bmac
approved these changes
Oct 25, 2017
Model names are normalized (so eg `store.peekRecord('fooBar',1) ===
store.peekRecord('foo-bar', 1)`) at most of the store API (`peekRecord`,
`findRecord` &c.) but notably absent is `push`.
This commit adds back model name normalization to `push`.
hjdivad
force-pushed
the
hjdivad/store-normalized-model-name
branch
from
4f4db40
to
a698568
Compare
|
good point @rwjblue |
hjdivad
changed the title
pushpush
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model names are normalized (so eg
store.peekRecord('fooBar',1) === store.peekRecord('foo-bar', 1)) at most of the store API (peekRecord,findRecord&c.) but notably absent ispush.This adds back model name normalization to push