Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support/deprecation for global DS variable in 3.0.0 #5287

Merged
merged 1 commit into from Jan 11, 2018
Merged

Remove support/deprecation for global DS variable in 3.0.0 #5287

merged 1 commit into from Jan 11, 2018

Conversation

bmac
Copy link
Member

@bmac bmac commented Dec 18, 2017

No description provided.

rwjblue
rwjblue requested changes Dec 19, 2017
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that we can remove more:

@bmac bmac merged commit 4c2eca6 into emberjs:master Jan 11, 2018
@bmac bmac deleted the remove-global-ds branch January 11, 2018 02:23
bmac added a commit that referenced this pull request Feb 12, 2018
@bmac
[CLEANUP beta] Remove support for global DS variable (#5287)
595783f 
(cherry picked from commit 4c2eca6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bmac @rwjblue