Fix failing test on master by adding an invalid inverse to trigger th… #5370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Mar 4, 2018
|
@bmac just to follow up: The thing this test was intended to capture (once However, investigating this made me realize there is still an uncovered case, I will PR a new test for it. |
|
Thanks for the follow up @runspired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e expected error
@runspired I'd like you eyes on this since I don't have a great mental model of all the moving pieces in this part of the code. It seems like Ember Data is already detecting there is no valid inverse for the
commentrelationship so it never generates an inverseMeta. So I added an explicit inverse that is invalid (because the other side hasinverse: null) to trigger the expected error.