make snapshot lazier and fix defaultValue #5428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
changed the title
adds an explicit test for laziness during findRecord cleanup test
runspired
force-pushed
the
fix-snapshot-default-value
branch
from
0dcc8b3
to
f6d248b
Compare
rwjblue
approved these changes
Apr 10, 2018
| @@ -17,18 +17,23 @@ import { get } from '@ember/object'; | |||
| */ | |||
| export default class Snapshot { | |||
| constructor(internalModel, options = {}) { | |||
| this._attributes = Object.create(null); | |||
| this.__attributes = null; | |||
There was a problem hiding this comment.
I'd like (at some point) to start discussing moving some of these state caches into weakmaps now that we can use them indiscriminately...
There was a problem hiding this comment.
I can try and tackle that enhancement... maybe use a similar weakmap implementation found elsewhere in the code?
|
Hi, thanks for this fix! Is it possible to include it in the next beta? |
sungraze
added a commit
to occrp/id-frontend
that referenced
this pull request
May 17, 2018
Failing test coming from emberjs/data#5444 so we need at least ember-data@3.2.0-beta-2. Using 3.2.0.beta-2 we get a fail related to defaultValue emberjs/data#5428 so we need a new beta :) Also maybe-import-regenerator seems to not import the generator (?) so I’ve added `includePolyfill: true` on babel opts. (mirage) Serialized rels on ticket reload to match the back-end. Otherwise fine, RIP my hype.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5426
Resolves #5419
Adds tests for
findRecordfor the very first time