Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] added module-unification adapter and adapter-test blueprints #5476

Merged
merged 1 commit into from
Jun 11, 2018
Merged

[Feature] added module-unification adapter and adapter-test blueprints #5476

merged 1 commit into from
Jun 11, 2018

Conversation

kevinansfield
Copy link
Contributor

Part of ember-cli/ember-cli#7530

This PR adds initial support for ember g adapter foo from a module unification app.

@GavinJoyce
Copy link
Member

@kevinansfield do you think the CI failure is just flakiness or is it something to address?

@kevinansfield
Copy link
Contributor Author

@GavinJoyce just flakiness I think? The error is from installing yarn before the tests even start:

$ yarn --version
1.3.2
$ curl -o- -L https://yarnpkg.com/install.sh | bash
bash: line 1: syntax error near unexpected token `newline'
bash: line 1: `<!DOCTYPE html>'
(23) Failed writing body

I'm guessing yarnpkg.com errored?

@GavinJoyce GavinJoyce mentioned this pull request Jun 6, 2018
Closed
29 tasks
@GavinJoyce
Copy link
Member

@kevinansfield perhaps rebase and force push to kick off CI again?

@kevinansfield
Copy link
Contributor Author

👍 done

GavinJoyce
GavinJoyce approved these changes Jun 11, 2018
View reviewed changes
Copy link
Member

@GavinJoyce GavinJoyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @kevinansfield, sorry for the delay in reviewing.

This looks good to me. /cc @rwjblue

@rwjblue rwjblue merged commit e195cb4 into emberjs:master Jun 11, 2018
@rwjblue
Copy link
Member

rwjblue commented Jun 11, 2018

Thank you @kevinansfield (and @GavinJoyce for reviewing)!

@dcyriller dcyriller mentioned this pull request Jun 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GavinJoyce GavinJoyce GavinJoyce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevinansfield @GavinJoyce @rwjblue