[BUGFIX] Lowercase header names in parseResponseHeaders #5489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmar910
force-pushed
the
lowercase-headers
branch
from
7afa0ea
to
312d7e0
Compare
bmac
reviewed
Jul 14, 2018
| let field = header | ||
| .substring(0, j) | ||
| .trim() | ||
| .toLowerCase(); |
There was a problem hiding this comment.
Would you also mind adding the original "unlowercased" field name to the headers object so anyone's app that is relying the the current behavior continues to work?
jmar910
force-pushed
the
lowercase-headers
branch
from
312d7e0
to
a4df4e1
Compare
|
@bmac feedback addressed! |
|
@bmac I feel per-spec we should deprecate the non-lower-cased version in a follow-up, unsure how to implement and probably needs an RFC, otherwise mega +1 on this |
runspired
requested changes
Jul 24, 2018
| @@ -92,7 +94,7 @@ test('ignores headers that do not contain a colon', function(assert) { | |||
|
|
|||
| let headers = parseResponseHeaders(headersString); | |||
|
|
|||
| assert.deepEqual(headers['Content-Encoding'], 'gzip', 'parses basic header pair'); | |||
| assert.deepEqual(headers['content-encoding'], 'gzip', 'parses basic header pair'); | |||
| assert.deepEqual(headers['apple'], 'pie', 'parses basic header pair'); | |||
| assert.equal(Object.keys(headers).length, 2, 'only has the one valid header'); | |||
There was a problem hiding this comment.
This assert's description is wrong (we had two and now we have three valid headers lol). The valid headers will be content-encoding Content-Encoding and apple
|
Oh whoops yep, I glossed over the fact that this changes the tests I
updated too 👌🏼
Will address.
…On Mon, Jul 23, 2018 at 10:55 PM Chris Thoburn ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In tests/unit/utils/parse-response-headers-test.js
<#5489 (comment)>:
> @@ -92,7 +94,7 @@ test('ignores headers that do not contain a colon', function(assert) {
let headers = parseResponseHeaders(headersString);
- assert.deepEqual(headers['Content-Encoding'], 'gzip', 'parses basic header pair');
+ assert.deepEqual(headers['content-encoding'], 'gzip', 'parses basic header pair');
assert.deepEqual(headers['apple'], 'pie', 'parses basic header pair');
assert.equal(Object.keys(headers).length, 2, 'only has the one valid header');
This assert's description is wrong (we had two and now we have three valid
headers lol). The valid headers will be content-encoding Content-Encoding
and apple
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5489 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEmHihqxePO8hzRLyWii5BEnN6sFAWYjks5uJoytgaJpZM4UoICC>
.
|
jmar910
force-pushed
the
lowercase-headers
branch
from
a4df4e1
to
db9946a
Compare
|
Anddddd we're back, should be good now @runspired |
runspired
approved these changes
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4952.
Pretty sure I got all the places we rely on uppercased header names, like in
generatedDetailedMessage🤞