Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency roundup! #5559

Merged
merged 4 commits into from
Aug 8, 2018
Merged

Dependency roundup! #5559

merged 4 commits into from
Aug 8, 2018

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Aug 8, 2018

No description provided.

`yarn lint:js` is used by CI to enforce linting, removing
ember-cli-eslint effectively means that no linting tests will be done as
part of the build.

This works around a long standing issue in ember-cli-eslint where the
directory provided to eslint when linting is incorrect, which throws an
error when `eslint-config-prettier` attempts to read the `.editorconfig`
file to infer base settings.
Copy link
Member Author

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some inline comments around the specific things being bumped major versions. Mostly to show why its fine for us to do without risk...

"amd-name-resolver": "0.0.7",
"babel-plugin-debug-macros": "^0.1.11",
"babel-plugin-ember-modules-api-polyfill": "^1.4.2",
"@ember/ordered-set": "^2.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major version bump due to dropping Node 4 support

"broccoli-debug": "^0.6.2",
"broccoli-file-creator": "^1.0.0",
"broccoli-debug": "^0.6.4",
"broccoli-file-creator": "^2.1.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major version bump due to dropping Node 0.12 support

"broccoli-funnel": "^2.0.1",
"broccoli-merge-trees": "^2.0.0",
"broccoli-rollup": "^2.1.0",
"broccoli-merge-trees": "^3.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major version bump due to dropping Node 4 support

"calculate-cache-key-for-tree": "^1.1.0",
"chalk": "^1.1.1",
"ember-cli-babel": "^6.15.0",
"chalk": "^2.4.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major version bump due to dropping Node 4 support (a few internal APIs changed, but we are not using them)

"ember-runtime-enumerable-includes-polyfill": "^2.0.0",
"git-repo-info": "^1.1.2",
"ember-runtime-enumerable-includes-polyfill": "^2.1.0",
"git-repo-info": "^2.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major version bump due to dropping Node 4 support

"ember-qunit-assert-helpers": "^0.2.1",
"ember-resolver": "^4.1.0",
"ember-resolver": "^5.0.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major version bump due to dropping Node 4 support (also drops "global fallbacks")

"ember-try": "^0.2.23",
"ember-watson": "^0.7.0",
"ember-source-channel-url": "^1.1.0",
"ember-try": "^1.0.0-beta.3",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major version bump due to dropping Node 4 support

"eslint-plugin-node": "^6.0.1",
"eslint-plugin-prettier": "2.6.0",
"fs-extra": "^6.0.1",
"eslint-plugin-node": "^7.0.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major version bump due to dropping Node 4 support (also adds more strict rules about things available in Node 10)

"fs-extra": "^6.0.1",
"eslint-plugin-node": "^7.0.1",
"eslint-plugin-prettier": "2.6.2",
"fs-extra": "^7.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major version bump due to dropping Node 4 support

"mocha-only-detector": "0.0.2",
"glob": "^7.1.2",
"loader.js": "^4.7.0",
"mocha": "^5.2.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes (Node 0.12 and 4 dropped, default "wait for exit" semantics, etc), seems good...

@rwjblue rwjblue merged commit 05bd20e into emberjs:master Aug 8, 2018
@rwjblue rwjblue deleted the update-deps branch August 8, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants