[CHORE] update contribution guidelines #5646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
force-pushed
the
cleanup-contributors
branch
from
8cd7d27
to
3930f5f
Compare
runspired
changed the title
MelSumner
reviewed
Sep 21, 2018
|
|
||
| 2. Search for similar issues. It's possible somebody has encountered | ||
| this bug already. | ||
| Before embarking on a fix, a new feature, or a refactor it is usually best to discuss the |
There was a problem hiding this comment.
Does ember-data follow an RFC process or does the team permit (bigger) proposed changes via PR + conversation?
There was a problem hiding this comment.
We do, it is described just a short bit after this.
bmac
reviewed
Sep 24, 2018
CONTRIBUTING.md
Outdated
| 6. [Draft an RFC](https://github.com/emberjs/rfcs#what-the-process-is) and share it with those you have | ||
| been discussing the ideas with. | ||
| 7. Publish your RFC by opening a PR to [emberjs/rfcs/](https://github.com/emberjs/rfcs/pulls?q=is%3Apr+is%3Aopen+label%3AT-ember-data) | ||
| * label your PR with `T-ember-data` |
There was a problem hiding this comment.
I'd add: "(or ask someone in #dev-ember-data to add the label if you lack the permission)"
bmac
reviewed
Sep 24, 2018
CONTRIBUTING.md
Outdated
|
|
||
| 4. Make the test pass. | ||
| This will allow the test suite to run as normal. |
There was a problem hiding this comment.
I might be a little more descriptive here. Maybe something along the lines of "This will ensure the new tests are only run when then feature is included in Ember Data."
bmac
reviewed
Sep 24, 2018
bmac
approved these changes
Sep 24, 2018
- cleanup PR label guide - add issue/PR templates - describe the RFC process - improve language of the CONTRIBUTOR guidelines
runspired
force-pushed
the
cleanup-contributors
branch
from
ba94aa5
to
11ae9f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't updated much of our contributor language and some time, this begins some work on that. Note, we need to update the
teamssection onemberjs.com