Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace mocha-only-detector with mocha/no-exclusive-tests rule #6125

Merged
merged 1 commit into from
May 22, 2019

Conversation

makepanic
Copy link
Contributor

@makepanic makepanic commented May 20, 2019

It's now using the no-exclusive-tests eslint rule

lint

fixes #6109

@makepanic
Copy link
Contributor Author

I think yarn sorted the packages/-build-infra/package.json dependencies after running yarn remove 🤔

@rwjblue
Copy link
Member

rwjblue commented May 21, 2019

Looks like ember-resource-metadata failed CI, not sure why (not much info in the logs).
yarn run v1.15.2
$ ./bin/test-external-partner-project.js ember-resource-metadata https://github.com/ef4/ember-resource-metadata.git
Preparing to test external project ember-resource-metadata located at https://github.com/ef4/ember-resource-metadata.git against this ember-data commit.
/Users/vsts/agent/2.150.3/work/1/s/bin/test-external-partner-project.js:70
  throw new Error(
  ^

Error: Install of https://github.com/ef4/ember-resource-metadata.git in /Users/vsts/agent/2.150.3/work/1/__external-test-cache/ember-resource-metadata for external project ember-resource-metadata testing failed.
    at Object.<anonymous> (/Users/vsts/agent/2.150.3/work/1/s/bin/test-external-partner-project.js:70:9)
    at Module._compile (internal/modules/cjs/loader.js:701:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:712:10)
    at Module.load (internal/modules/cjs/loader.js:600:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:539:12)
    at Function.Module._load (internal/modules/cjs/loader.js:531:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:754:12)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:622:3)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
##[error]Bash exited with code '1'.

@runspired runspired merged commit 9f995ec into emberjs:master May 22, 2019
pete-the-pete pushed a commit to pete-the-pete/data that referenced this pull request Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CHORE] replace mocha-only-detector with eslint rule for use of .only
3 participants