remove remaining sinceToken and update docs #6168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@runspired I was a bit confused as a handful of tests fail on master now, but figured I'd open the PR and we can sort out the failures as part of review. |
ghost
commented
Jun 18, 2019
> the TL;DR here is that the adapter APIs (which are public) still have a "slot" for sinceToken per runspired
runspired
approved these changes
Jun 19, 2019
runspired
reviewed
Jun 19, 2019
runspired
reviewed
Jun 19, 2019
runspired
requested changes
Jun 19, 2019
runspired
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/emberjs/data/pull/6163/files
and #6164.