Skip to content

Commit

Permalink
[DOCS adapter] remove remaining sinceToken and update docs (emberjs#6168
Browse files Browse the repository at this point in the history
)

the TL;DR here is that the adapter APIs (which are public) still have a "slot" for sinceToken
per runspired
  • Loading branch information
efx authored and pliljegr committed Jul 23, 2019
1 parent 5ae2a8d commit 1321bb7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
7 changes: 3 additions & 4 deletions packages/adapter/addon/adapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,10 @@ export default EmberObject.extend({
import $ from 'jquery';
export default DS.Adapter.extend({
findAll(store, type, sinceToken) {
let query = { since: sinceToken };
findAll(store, type) {
return new RSVP.Promise(function(resolve, reject) {
$.getJSON(`/${type.modelName}`, query).then(function(data) {
$.getJSON(`/${type.modelName}`).then(function(data) {
resolve(data);
}, function(jqXHR) {
reject(jqXHR);
Expand All @@ -147,7 +146,7 @@ export default EmberObject.extend({
@method findAll
@param {DS.Store} store
@param {DS.Model} type
@param {String} sinceToken
@param {undefined} neverSet a value is never provided to this argument
@param {DS.SnapshotRecordArray} snapshotRecordArray
@return {Promise} promise
*/
Expand Down
2 changes: 1 addition & 1 deletion packages/adapter/addon/rest.js
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ const RESTAdapter = Adapter.extend(BuildURLMixin, {
@method findAll
@param {DS.Store} store
@param {DS.Model} type
@param {String} sinceToken
@param {undefined} neverSet a value is never provided to this argument
@param {DS.SnapshotRecordArray} snapshotRecordArray
@return {Promise} promise
*/
Expand Down

0 comments on commit 1321bb7

Please sign in to comment.