[BUGFIX release] fix type overrides #6256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that this is a fix for a regression, can we write a test (maybe just a shell script we can |
|
Opened an issue for adding a test: #6261 Likely what we want is something that uses the latest ember-cli, ember-cli-typescript, ember-data to create an app, scaffold a few things (adapters / serializers / models) and ensure it can build without erring |
runspired
added a commit
that referenced
this pull request
Jul 18, 2019
* [BUGFIX release] safer type stripping strategy * remove uneeded command parts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates how we guard against stripping types by:
ts:precompile.d.tsfiles in our.npmignore/types/directory in each package where overrides liveSee https://typed-ember.github.io/ember-cli-typescript/versions/master/docs/ts-guide/with-addons#publishing