Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX RELEASE] Fix generating from blueprints #6274

Merged
merged 6 commits into from
Jul 24, 2019
Merged

[BUGFIX RELEASE] Fix generating from blueprints #6274

merged 6 commits into from
Jul 24, 2019

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Jul 23, 2019 •
edited
Loading

This fixes unable to generate models, adapters, serializers, and transforms.

Note: This is my first attempt to commit to ember-data.

Also fixes #6263

Please note that we could not just override path or filesPath because path gets overwritten on init and filesPath is patched from outside the blueprints object.

Update: Rebased against master

@Gaurav0 Gaurav0 mentioned this pull request Jul 23, 2019
Merged
runspired
runspired approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good and a huge thanks! This PR should be rebased off of master and pointed there though. We will then backport it to release once on master.

Thanks again :)

@Gaurav0 Gaurav0 changed the base branch from release to master July 23, 2019 16:50
@runspired runspired merged commit aa2c0d5 into emberjs:master Jul 24, 2019
@Gaurav0 Gaurav0 deleted the fix_generation branch July 24, 2019 13:57
runspired pushed a commit that referenced this pull request Jul 26, 2019
@Gaurav0 @runspired
[BUGFIX RELEASE] Fix generating from blueprints (#6274)
919eca3 
* [BUGFIX RELEASE] Fix generating from blueprints

* Revert "skip node tests"

This reverts commit db5cac2.

* fix failing node tests

* fix prettier eslint

* blueprintPath -> root

* fix eslint prettier again
runspired added a commit that referenced this pull request Jul 26, 2019
@runspired
[BUGFIX RELEASE] Fix generating from blueprints (#6274) (#6286)
885984f 
* [BUGFIX RELEASE] Fix generating from blueprints

* Revert "skip node tests"

This reverts commit db5cac2.

* fix failing node tests

* fix prettier eslint

* blueprintPath -> root

* fix eslint prettier again
@ghost ghost mentioned this pull request Jul 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

@runspired runspired runspired approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI unskip node:test for blueprints
3 participants
@Gaurav0 @rwjblue @runspired