[BUGFIX beta] Fix Rollup warning about unresolved dependency #6316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following warning: ``` '@ember-data/store' is imported by -private/system/model/model.js, but could not be resolved – treating it as an external dependency ```
rwjblue
approved these changes
Aug 12, 2019
|
@HeroicEric I'm interested in joining the external parter tests with ember-local-storage. How can I apply? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #6098
Fixes the following warning:
I'm not sure I understand why but it seems like Rollup does not like the other style of import.
This also resolves an issue with the external partner tests for ember-observer. You can see an example of what happens without this at https://dev.azure.com/ember-data/emberjs/_build/results?buildId=962