Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting ID on Record Data from DS.Model #6775

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Fix setting ID on Record Data from DS.Model #6775

merged 1 commit into from
Nov 20, 2019

Conversation

igorT
Copy link
Member

@igorT igorT commented Nov 20, 2019

No description provided.

@github-actions
Copy link

Asset Size Report for 683ac50

EmberData increased by 91.0 B uncompressed but decreased by 107.0 B compressed

Warnings

The uncompressed size of the package @ember-data/store has increased by 56.0 B.
The uncompressed size of the package @ember-data/record-data has increased by 35.0 B.

Changeset


EmberData 160.14 KB +91.0 B (34.07 KB -107.0 B compressed)
    @ember-data/store 71.72 KB +56.0 B (15.26 KB -44.66 B compressed)
        @ember-data/store/-private 70.81 KB +56.0 B (15.06 KB -43.95 B compressed)
    @ember-data/record-data 22.97 KB +35.0 B (4.89 KB -10.67 B compressed)
        @ember-data/record-data/-private 22.97 KB +35.0 B (4.89 KB -10.67 B compressed)
Full Asset Analysis 

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '160.14 KB' │
│ compressed │ '34.21 KB'  │
│  packages  │      9      │
│  modules   │     47      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '71.72 KB' │
│  compressed  │ '15.32 KB' │
│ % Of Library │   '44.8'   │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                    | 70.81 KB  | 15.12 KB   | 98.7          | 44.2
	@ember-data/store/index                       | 936.00 B  | 199.93 B   | 1.3           | 0.6

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.97 KB' │
│  compressed  │ '4.91 KB'  │
│ % Of Library │   '14.3'   │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private              | 22.97 KB  | 4.91 KB    | 100.0         | 14.3

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.30 KB' │
│  compressed  │ '4.12 KB'  │
│ % Of Library │   '12.1'   │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                   | 7.10 KB   | 1.52 KB    | 36.8          | 4.4
	@ember-data/serializer/-private               | 5.36 KB   | 1.15 KB    | 27.8          | 3.3
	@ember-data/serializer/json-api               | 3.71 KB   | 810.85 B   | 19.2          | 2.3
	@ember-data/serializer/rest                   | 2.68 KB   | 585.92 B   | 13.9          | 1.7
	@ember-data/serializer/index                  | 243.00 B  | 51.90 B    | 1.2           | 0.1
	@ember-data/serializer/transform              | 215.00 B  | 45.92 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '14.57 KB' │
│  compressed  │ '3.11 KB'  │
│ % Of Library │   '9.1'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                      | 7.65 KB   | 1.63 KB    | 52.5          | 4.8
	@ember-data/adapter/-private                  | 3.50 KB   | 765.56 B   | 24.0          | 2.2
	@ember-data/adapter/error                     | 1.91 KB   | 418.45 B   | 13.1          | 1.2
	@ember-data/adapter/json-api                  | 830.00 B  | 177.29 B   | 5.6           | 0.5
	@ember-data/adapter/index                     | 719.00 B  | 153.58 B   | 4.8           | 0.4

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '10.22 KB' │
│  compressed  │ '2.18 KB'  │
│ % Of Library │   '6.4'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                    | 9.75 KB   | 2.08 KB    | 95.4          | 6.1
	@ember-data/model/index                       | 486.00 B  | 103.81 B   | 4.6           | 0.3

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.72 KB' │
│  compressed  │ '2.08 KB' │
│ % Of Library │   '6.1'   │
└──────────────┴───────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                              | 2.42 KB   | 529.53 B   | 24.9          | 1.5
	ember-data/-private                           | 1.98 KB   | 433.40 B   | 20.4          | 1.2
	ember-data/adapters/errors                    | 1.19 KB   | 259.95 B   | 12.2          | 0.7
	ember-data/setup-container                    | 503.00 B  | 107.44 B   | 5.1           | 0.3
	ember-data/store                              | 406.00 B  | 86.72 B    | 4.1           | 0.2
	ember-data/relationships                      | 318.00 B  | 67.92 B    | 3.2           | 0.2
	ember-data/serializers/embedded-records-mixin | 274.00 B  | 58.52 B    | 2.8           | 0.2
	ember-data/serializers/json-api               | 251.00 B  | 53.61 B    | 2.5           | 0.2
	ember-data/adapters/json-api                  | 245.00 B  | 52.33 B    | 2.5           | 0.1
	ember-data/serializers/json                   | 243.00 B  | 51.90 B    | 2.4           | 0.1
	ember-data/serializers/rest                   | 243.00 B  | 51.90 B    | 2.4           | 0.1
	ember-data/transform                          | 241.00 B  | 51.47 B    | 2.4           | 0.1
	ember-data/adapters/rest                      | 237.00 B  | 50.62 B    | 2.4           | 0.1
	ember-data/serializer                         | 232.00 B  | 49.55 B    | 2.3           | 0.1
	ember-data/adapter                            | 226.00 B  | 48.27 B    | 2.3           | 0.1
	ember-data/model                              | 222.00 B  | 47.42 B    | 2.2           | 0.1
	ember-data/attr                               | 218.00 B  | 46.56 B    | 2.2           | 0.1
	ember-data/initialize-store-service           | 207.00 B  | 44.21 B    | 2.1           | 0.1
	ember-data/version                            | 162.00 B  | 34.60 B    | 1.6           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.90 KB' │
│  compressed  │ '1.69 KB' │
│ % Of Library │   '4.9'   │
└──────────────┴───────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector          | 2.75 KB   | 601.72 B   | 34.8          | 1.7
	ember-inflector/lib/system/inflections        | 1.57 KB   | 343.90 B   | 19.9          | 1.0
	ember-inflector/index                         | 1.12 KB   | 245.22 B   | 14.2          | 0.7
	ember-inflector/lib/ext/string                | 783.00 B  | 167.25 B   | 9.7           | 0.5
	ember-inflector/lib/system                    | 452.00 B  | 96.55 B    | 5.6           | 0.3
	ember-inflector/lib/system/string             | 351.00 B  | 74.97 B    | 4.3           | 0.2
	ember-inflector/lib/helpers/pluralize         | 348.00 B  | 74.33 B    | 4.3           | 0.2
	ember-inflector/lib/utils/make-helper         | 308.00 B  | 65.79 B    | 3.8           | 0.2
	ember-inflector/lib/helpers/singularize       | 271.00 B  | 57.88 B    | 3.4           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.68 KB'  │
│  compressed  │ '585.92 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                       | 2.19 KB   | 479.33 B   | 81.8          | 1.4
	@ember-data/debug/setup                       | 499.00 B  | 106.58 B   | 18.2          | 0.3

Package: @ember/ordered-set
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '1.05 KB'  │
│  compressed  │ '230.26 B' │
│ % Of Library │   '0.7'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember/ordered-set/index                      | 1.05 KB   | 230.26 B   | 100.0         | 0.7

@github-actions
Copy link

Asset Size Report for 341d4df

EmberData increased by 92.0 B uncompressed but decreased by 91.0 B compressed

Warnings

The uncompressed size of the package @ember-data/store has increased by 56.0 B.
The uncompressed size of the package @ember-data/record-data has increased by 36.0 B.

Changeset


EmberData 160.14 KB +92.0 B (34.08 KB -91.0 B compressed)
    @ember-data/store 71.72 KB +56.0 B (15.26 KB -37.59 B compressed)
        @ember-data/store/-private 70.81 KB +56.0 B (15.07 KB -36.97 B compressed)
    @ember-data/record-data 22.97 KB +36.0 B (4.89 KB -8.19 B compressed)
        @ember-data/record-data/-private 22.97 KB +36.0 B (4.89 KB -8.19 B compressed)
Full Asset Analysis 

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '160.14 KB' │
│ compressed │ '34.16 KB'  │
│  packages  │      9      │
│  modules   │     47      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '71.72 KB' │
│  compressed  │ '15.30 KB' │
│ % Of Library │   '44.8'   │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                    | 70.81 KB  | 15.10 KB   | 98.7          | 44.2
	@ember-data/store/index                       | 936.00 B  | 199.65 B   | 1.3           | 0.6

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.97 KB' │
│  compressed  │ '4.90 KB'  │
│ % Of Library │   '14.3'   │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private              | 22.97 KB  | 4.90 KB    | 100.0         | 14.3

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.30 KB' │
│  compressed  │ '4.12 KB'  │
│ % Of Library │   '12.1'   │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                   | 7.10 KB   | 1.52 KB    | 36.8          | 4.4
	@ember-data/serializer/-private               | 5.36 KB   | 1.14 KB    | 27.8          | 3.3
	@ember-data/serializer/json-api               | 3.71 KB   | 809.71 B   | 19.2          | 2.3
	@ember-data/serializer/rest                   | 2.68 KB   | 585.09 B   | 13.9          | 1.7
	@ember-data/serializer/index                  | 243.00 B  | 51.83 B    | 1.2           | 0.1
	@ember-data/serializer/transform              | 215.00 B  | 45.86 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '14.57 KB' │
│  compressed  │ '3.11 KB'  │
│ % Of Library │   '9.1'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                      | 7.65 KB   | 1.63 KB    | 52.5          | 4.8
	@ember-data/adapter/-private                  | 3.50 KB   | 764.49 B   | 24.0          | 2.2
	@ember-data/adapter/error                     | 1.91 KB   | 417.86 B   | 13.1          | 1.2
	@ember-data/adapter/json-api                  | 830.00 B  | 177.04 B   | 5.6           | 0.5
	@ember-data/adapter/index                     | 719.00 B  | 153.36 B   | 4.8           | 0.4

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '10.22 KB' │
│  compressed  │ '2.18 KB'  │
│ % Of Library │   '6.4'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                    | 9.75 KB   | 2.08 KB    | 95.4          | 6.1
	@ember-data/model/index                       | 486.00 B  | 103.66 B   | 4.6           | 0.3

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.72 KB' │
│  compressed  │ '2.07 KB' │
│ % Of Library │   '6.1'   │
└──────────────┴───────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                              | 2.42 KB   | 528.78 B   | 24.9          | 1.5
	ember-data/-private                           | 1.98 KB   | 432.79 B   | 20.4          | 1.2
	ember-data/adapters/errors                    | 1.19 KB   | 259.59 B   | 12.2          | 0.7
	ember-data/setup-container                    | 503.00 B  | 107.29 B   | 5.1           | 0.3
	ember-data/store                              | 406.00 B  | 86.60 B    | 4.1           | 0.2
	ember-data/relationships                      | 318.00 B  | 67.83 B    | 3.2           | 0.2
	ember-data/serializers/embedded-records-mixin | 274.00 B  | 58.44 B    | 2.8           | 0.2
	ember-data/serializers/json-api               | 251.00 B  | 53.53 B    | 2.5           | 0.2
	ember-data/adapters/json-api                  | 245.00 B  | 52.26 B    | 2.5           | 0.1
	ember-data/serializers/json                   | 243.00 B  | 51.83 B    | 2.4           | 0.1
	ember-data/serializers/rest                   | 243.00 B  | 51.83 B    | 2.4           | 0.1
	ember-data/transform                          | 241.00 B  | 51.40 B    | 2.4           | 0.1
	ember-data/adapters/rest                      | 237.00 B  | 50.55 B    | 2.4           | 0.1
	ember-data/serializer                         | 232.00 B  | 49.48 B    | 2.3           | 0.1
	ember-data/adapter                            | 226.00 B  | 48.20 B    | 2.3           | 0.1
	ember-data/model                              | 222.00 B  | 47.35 B    | 2.2           | 0.1
	ember-data/attr                               | 218.00 B  | 46.50 B    | 2.2           | 0.1
	ember-data/initialize-store-service           | 207.00 B  | 44.15 B    | 2.1           | 0.1
	ember-data/version                            | 162.00 B  | 34.55 B    | 1.6           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.90 KB' │
│  compressed  │ '1.68 KB' │
│ % Of Library │   '4.9'   │
└──────────────┴───────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector          | 2.75 KB   | 600.88 B   | 34.8          | 1.7
	ember-inflector/lib/system/inflections        | 1.57 KB   | 343.42 B   | 19.9          | 1.0
	ember-inflector/index                         | 1.12 KB   | 244.87 B   | 14.2          | 0.7
	ember-inflector/lib/ext/string                | 783.00 B  | 167.01 B   | 9.7           | 0.5
	ember-inflector/lib/system                    | 452.00 B  | 96.41 B    | 5.6           | 0.3
	ember-inflector/lib/system/string             | 351.00 B  | 74.87 B    | 4.3           | 0.2
	ember-inflector/lib/helpers/pluralize         | 348.00 B  | 74.23 B    | 4.3           | 0.2
	ember-inflector/lib/utils/make-helper         | 308.00 B  | 65.69 B    | 3.8           | 0.2
	ember-inflector/lib/helpers/singularize       | 271.00 B  | 57.80 B    | 3.4           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.68 KB'  │
│  compressed  │ '585.09 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                       | 2.19 KB   | 478.65 B   | 81.8          | 1.4
	@ember-data/debug/setup                       | 499.00 B  | 106.43 B   | 18.2          | 0.3

Package: @ember/ordered-set
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '1.05 KB'  │
│  compressed  │ '229.94 B' │
│ % Of Library │   '0.7'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember/ordered-set/index                      | 1.05 KB   | 229.94 B   | 100.0         | 0.7

@igorT igorT requested a review from runspired November 20, 2019 19:38
@igorT igorT changed the title WIP set id Fix setting ID on Record Data from DS.Model Nov 20, 2019
@igorT igorT added Bug 🏷️ bug This PR primarily fixes a reported issue 🎯 beta PR should be backported to beta 🎯 lts The PR should be backported to the most recent LTS 🎯 release PR should be backported to release labels Nov 20, 2019
@github-actions
Copy link

Asset Size Report for 32cec61

EmberData increased by 92.0 B uncompressed but decreased by 91.0 B compressed

Warnings

The uncompressed size of the package @ember-data/store has increased by 56.0 B.
The uncompressed size of the package @ember-data/record-data has increased by 36.0 B.

Changeset


EmberData 160.14 KB +92.0 B (34.08 KB -91.0 B compressed)
    @ember-data/store 71.72 KB +56.0 B (15.26 KB -37.59 B compressed)
        @ember-data/store/-private 70.81 KB +56.0 B (15.07 KB -36.97 B compressed)
    @ember-data/record-data 22.97 KB +36.0 B (4.89 KB -8.19 B compressed)
        @ember-data/record-data/-private 22.97 KB +36.0 B (4.89 KB -8.19 B compressed)
Full Asset Analysis 

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '160.14 KB' │
│ compressed │ '34.16 KB'  │
│  packages  │      9      │
│  modules   │     47      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '71.72 KB' │
│  compressed  │ '15.30 KB' │
│ % Of Library │   '44.8'   │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                    | 70.81 KB  | 15.10 KB   | 98.7          | 44.2
	@ember-data/store/index                       | 936.00 B  | 199.65 B   | 1.3           | 0.6

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.97 KB' │
│  compressed  │ '4.90 KB'  │
│ % Of Library │   '14.3'   │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private              | 22.97 KB  | 4.90 KB    | 100.0         | 14.3

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.30 KB' │
│  compressed  │ '4.12 KB'  │
│ % Of Library │   '12.1'   │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                   | 7.10 KB   | 1.52 KB    | 36.8          | 4.4
	@ember-data/serializer/-private               | 5.36 KB   | 1.14 KB    | 27.8          | 3.3
	@ember-data/serializer/json-api               | 3.71 KB   | 809.71 B   | 19.2          | 2.3
	@ember-data/serializer/rest                   | 2.68 KB   | 585.09 B   | 13.9          | 1.7
	@ember-data/serializer/index                  | 243.00 B  | 51.83 B    | 1.2           | 0.1
	@ember-data/serializer/transform              | 215.00 B  | 45.86 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '14.57 KB' │
│  compressed  │ '3.11 KB'  │
│ % Of Library │   '9.1'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                      | 7.65 KB   | 1.63 KB    | 52.5          | 4.8
	@ember-data/adapter/-private                  | 3.50 KB   | 764.49 B   | 24.0          | 2.2
	@ember-data/adapter/error                     | 1.91 KB   | 417.86 B   | 13.1          | 1.2
	@ember-data/adapter/json-api                  | 830.00 B  | 177.04 B   | 5.6           | 0.5
	@ember-data/adapter/index                     | 719.00 B  | 153.36 B   | 4.8           | 0.4

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '10.22 KB' │
│  compressed  │ '2.18 KB'  │
│ % Of Library │   '6.4'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                    | 9.75 KB   | 2.08 KB    | 95.4          | 6.1
	@ember-data/model/index                       | 486.00 B  | 103.66 B   | 4.6           | 0.3

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.72 KB' │
│  compressed  │ '2.07 KB' │
│ % Of Library │   '6.1'   │
└──────────────┴───────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                              | 2.42 KB   | 528.78 B   | 24.9          | 1.5
	ember-data/-private                           | 1.98 KB   | 432.79 B   | 20.4          | 1.2
	ember-data/adapters/errors                    | 1.19 KB   | 259.59 B   | 12.2          | 0.7
	ember-data/setup-container                    | 503.00 B  | 107.29 B   | 5.1           | 0.3
	ember-data/store                              | 406.00 B  | 86.60 B    | 4.1           | 0.2
	ember-data/relationships                      | 318.00 B  | 67.83 B    | 3.2           | 0.2
	ember-data/serializers/embedded-records-mixin | 274.00 B  | 58.44 B    | 2.8           | 0.2
	ember-data/serializers/json-api               | 251.00 B  | 53.53 B    | 2.5           | 0.2
	ember-data/adapters/json-api                  | 245.00 B  | 52.26 B    | 2.5           | 0.1
	ember-data/serializers/json                   | 243.00 B  | 51.83 B    | 2.4           | 0.1
	ember-data/serializers/rest                   | 243.00 B  | 51.83 B    | 2.4           | 0.1
	ember-data/transform                          | 241.00 B  | 51.40 B    | 2.4           | 0.1
	ember-data/adapters/rest                      | 237.00 B  | 50.55 B    | 2.4           | 0.1
	ember-data/serializer                         | 232.00 B  | 49.48 B    | 2.3           | 0.1
	ember-data/adapter                            | 226.00 B  | 48.20 B    | 2.3           | 0.1
	ember-data/model                              | 222.00 B  | 47.35 B    | 2.2           | 0.1
	ember-data/attr                               | 218.00 B  | 46.50 B    | 2.2           | 0.1
	ember-data/initialize-store-service           | 207.00 B  | 44.15 B    | 2.1           | 0.1
	ember-data/version                            | 162.00 B  | 34.55 B    | 1.6           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.90 KB' │
│  compressed  │ '1.68 KB' │
│ % Of Library │   '4.9'   │
└──────────────┴───────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector          | 2.75 KB   | 600.88 B   | 34.8          | 1.7
	ember-inflector/lib/system/inflections        | 1.57 KB   | 343.42 B   | 19.9          | 1.0
	ember-inflector/index                         | 1.12 KB   | 244.87 B   | 14.2          | 0.7
	ember-inflector/lib/ext/string                | 783.00 B  | 167.01 B   | 9.7           | 0.5
	ember-inflector/lib/system                    | 452.00 B  | 96.41 B    | 5.6           | 0.3
	ember-inflector/lib/system/string             | 351.00 B  | 74.87 B    | 4.3           | 0.2
	ember-inflector/lib/helpers/pluralize         | 348.00 B  | 74.23 B    | 4.3           | 0.2
	ember-inflector/lib/utils/make-helper         | 308.00 B  | 65.69 B    | 3.8           | 0.2
	ember-inflector/lib/helpers/singularize       | 271.00 B  | 57.80 B    | 3.4           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.68 KB'  │
│  compressed  │ '585.09 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                       | 2.19 KB   | 478.65 B   | 81.8          | 1.4
	@ember-data/debug/setup                       | 499.00 B  | 106.43 B   | 18.2          | 0.3

Package: @ember/ordered-set
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '1.05 KB'  │
│  compressed  │ '229.94 B' │
│ % Of Library │   '0.7'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember/ordered-set/index                      | 1.05 KB   | 229.94 B   | 100.0         | 0.7

mike-north
mike-north reviewed Nov 20, 2019
View reviewed changes
Copy link
Contributor

@mike-north mike-north left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS 👍

packages/store/addon/-private/system/model/internal-model.ts
@@ -1359,6 +1359,10 @@ export default class InternalModel {

if (didChange && id !== null) {
this.store.setRecordId(this.modelName, id, this.clientId);
// internal set of ID to get it to RecordData from DS.Model
if (this._recordData.__setId) {
this._recordData.__setId(id);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may want to leave yourself a note to use optional chaining here when TS 3.7 is safe to adopt

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, want to leave the check more loud for the reader/explicit in this case

runspired
runspired reviewed Nov 20, 2019
View reviewed changes
packages/-ember-data/tests/unit/model-test.js
@@ -372,6 +372,13 @@ module('unit/model - Model', function(hooks) {
assert.equal(idChange, 0);
person._internalModel.setId('john');
assert.equal(idChange, 1);
let recordData = recordDataFor(person);
assert.equal(
recordData.getResourceIdentifier().id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@igorT igorT merged commit 118a047 into master Nov 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the igor/record-data-set-id branch November 20, 2019 20:40
@igorT igorT mentioned this pull request Nov 20, 2019
Merged
igorT added a commit that referenced this pull request Nov 20, 2019
@igorT
[BUGFIX] Set IDs on Record Data when mutating DS Model (#6775)
24b5967
igorT added a commit that referenced this pull request Nov 20, 2019
@igorT
[BUGFIX] Set IDs on Record Data when mutating DS Model (#6775)
f11491e
igorT added a commit that referenced this pull request Nov 20, 2019
@igorT
[BUGFIX] Set IDs on Record Data when mutating DS Model (#6775)
33207dd
igorT added a commit that referenced this pull request Nov 21, 2019
@igorT
[BUGFIX] Set IDs on Record Data when mutating DS Model (#6775) (#6779)
e44f652
igorT added a commit that referenced this pull request Nov 21, 2019
@igorT
[BUGFIX] Set IDs on Record Data when mutating DS Model (#6775) (#6780)
db6967f
igorT added a commit that referenced this pull request Nov 21, 2019
@igorT
[BUGFIX] Set IDs on Record Data when mutating DS Model (#6775) (#6778)
c5f8580
@igorT igorT removed 🎯 beta PR should be backported to beta 🎯 lts The PR should be backported to the most recent LTS target:lts-3-12 labels Nov 21, 2019
@igorT igorT removed target:lts-3-8 🎯 release PR should be backported to release labels Nov 21, 2019
@runspired runspired removed the Bug label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-north mike-north mike-north left review comments

@runspired runspired runspired approved these changes

Assignees
No one assigned
Labels
🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igorT @mike-north @runspired