[DOC] create a howto for testing pull requests #7019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Feb 19, 2020
| @@ -12,6 +12,29 @@ We have provided an [issue template](.github/bug.md) what will help guide you th | |||
| If you are unsure if something is a bug, the `#ember-data` channel on [Discord](https://discord.gg/zT3asNS) is | |||
| a great place to ask for help! | |||
|
|
|||
| #### Testing ember data source directly | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
rwjblue
reviewed
Feb 19, 2020
MelSumner
approved these changes
Feb 27, 2020
|
@efx it looks like there are a couple of failing tests. Can you look to figure out why? |
|
@MelSumner certainly! I'm swamped with an internal release so will need to take a look at this after 3/3. I plan to revise the verbiage per Rob's suggestions and will dig into whether the CI failures are legitimate. |
ghost
mentioned this pull request
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly document how to link ember data in your application. Came up as a result of someone wanting to helpfully test an outstanding PR.