[Test]: fix for DataWrapper refactor in emberjs #7435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Asset Size Report for ee8efc4 IE11 Builds EmberData increased by 53.0 B (-47.0 B compressed) which is within the allowed tolerance of 75 bytes uncompressedWarningsThe uncompressed size of the package @ember-data/store has increased by 41.0 B. Changeset Full Asset Analysis (IE11)Modern Builds EmberData increased by 53.0 B (-47.0 B compressed) which is within the allowed tolerance of 75 bytes uncompressedWarningsThe uncompressed size of the package @ember-data/store has increased by 41.0 B. Changeset Full Asset Analysis (Modern)Modern Builds (No Rollup) The size of the library EmberData has increased by 95.0 B (66.0 B compressed) which exceeds the failure threshold of 75 bytes.WarningsThe uncompressed size of the package @ember-data/store has increased by 83.0 B. Changeset Full Asset Analysis (Modern) |
|
Performance Report for ee8efc4 Relationship Analysis |
snewcomer
force-pushed
the
sn/beta-failures
branch
from
1bb9b38
to
7707e3a
Compare
snewcomer
changed the title
snewcomer
force-pushed
the
sn/beta-failures
branch
3 times, most recently
from
6995288
to
fa6d521
Compare
snewcomer
force-pushed
the
sn/beta-failures
branch
from
fa6d521
to
03a2594
Compare
…r destroyed flag has flipped
… factoryManager is unable to have new properties set on it
rwjblue
reviewed
Mar 24, 2021
package.json
Outdated
| @@ -41,6 +41,7 @@ | |||
| "@babel/plugin-transform-typescript": "^7.9.6", | |||
| "@ember/edition-utils": "^1.2.0", | |||
| "@ember/optional-features": "^1.3.0", | |||
| "@ember/test-helpers": "^2.2.5", | |||
There was a problem hiding this comment.
Hmm, this won't work unless we also do the rest of the ember-qunit@5 updates.
packages/-ember-data/package.json
Outdated
| "ember-cli-typescript": "^4.0.0", | ||
| "ember-inflector": "^4.0.1" | ||
| }, | ||
| "devDependencies": { | ||
| "@babel/plugin-transform-typescript": "^7.9.6", | ||
| "@ember-data/unpublished-test-infra": "3.27.0-alpha.0", | ||
| "@ember/optional-features": "^1.3.0", | ||
| "@ember/test-helpers": "^2.2.5", |
|
|
||
| post.unloadRecord(); | ||
|
|
||
| await settled(); | ||
|
|
||
| assert.equal(removedIndex, 1, 'We are notified of the start index of a removal when we remove posts'); | ||
| assert.equal(removedCount, 1, 'We are notified of the total posts removed'); | ||
| if (gte('3.26.0')) { |
There was a problem hiding this comment.
Should probably add a comment about why we expect these to differ for 3.26+
packages/debug/package.json
Outdated
| "ember-cli-test-info": "^1.0.0", | ||
| "ember-cli-typescript": "^4.0.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@ember-data/unpublished-test-infra": "3.27.0-alpha.0", | ||
| "@ember/optional-features": "^1.3.0", | ||
| "@ember/test-helpers": "^2.2.5", |
snewcomer
force-pushed
the
sn/beta-failures
branch
from
9febd5a
to
2981e7f
Compare
This reverts commit 4b74236.
igorT
reviewed
Mar 26, 2021
| @@ -9,6 +9,8 @@ module.exports = Object.assign({}, addonBaseConfig, { | |||
| shouldRollupPrivate: true, | |||
| externalDependenciesForPrivateModule() { | |||
| return [ | |||
| 'ember', | |||
igorT
reviewed
Mar 26, 2021
| @@ -11,7 +11,7 @@ module('integration/store/creation-recursion', function(hooks) { | |||
| let storeFactory = this.owner.factoryFor('service:store'); | |||
|
|
|||
| this.owner.unregister('service:store'); | |||
| this.owner.register('service:store', storeFactory); | |||
| this.owner.register('service:store', storeFactory.class); | |||
There was a problem hiding this comment.
Ember asserts if you pass the factoryFor result directly to register now
igorT
reviewed
Mar 26, 2021
| @@ -437,7 +437,7 @@ export default class RecordDataDefault implements RelationshipRecordData { | |||
| this._destroyRelationships(); | |||
| this.reset(); | |||
| if (!this._scheduledDestroy) { | |||
| this._scheduledDestroy = run.backburner.schedule('destroy', this, '_cleanupOrphanedRecordDatas'); | |||
| this._scheduledDestroy = emberBackburner.schedule('destroy', this, '_cleanupOrphanedRecordDatas'); | |||
There was a problem hiding this comment.
Does run complain now when you access backburner on it?
igorT
reviewed
Mar 26, 2021
| @@ -6,6 +6,7 @@ import { registerWaiter } from '@ember/test'; | |||
| import { DEBUG } from '@glimmer/env'; | |||
| import Ember from 'ember'; | |||
|
|
|||
| // TODO: expose Ember._Backburner as `import { _Backburner } from '@ember/runloop'` in ember-rfc176-data + emberjs/ember.js | |||
There was a problem hiding this comment.
Can you please clarify this a bit, not quite sure what the future work required is
There was a problem hiding this comment.
Ember doesn't expose the constructor for Backburner in a modules API
igorT
reviewed
Mar 26, 2021
| @@ -6,7 +6,7 @@ import { A } from '@ember/array'; | |||
| import { assert } from '@ember/debug'; | |||
| import { get, set } from '@ember/object'; | |||
| import { assign } from '@ember/polyfills'; | |||
| import { run as emberRunloop } from '@ember/runloop'; | |||
| import { _backburner as emberBackburner } from '@ember/runloop'; | |||
There was a problem hiding this comment.
So its clearer across the board when we are working with Ember's backburner instances vs our internal
snewcomer
added a commit
that referenced
this pull request
Mar 27, 2021
* Fix deprecations for accessing run.* (e.g. `run.next(...)`) * update to ember-cli-babel 7.26.3 And various other fixes for enabling ember-canary to pass Co-authored-by: Robert Jackson <rjackson@linkedin.com>
snewcomer
added a commit
that referenced
this pull request
Mar 27, 2021
* Update Changelog for v3.26.0 * [Test]: fix for DataWrapper refactor in emberjs (#7435) * Fix deprecations for accessing run.* (e.g. `run.next(...)`) * update to ember-cli-babel 7.26.3 And various other fixes for enabling ember-canary to pass Co-authored-by: Robert Jackson <rjackson@linkedin.com> Co-authored-by: Robert Jackson <rjackson@linkedin.com>
25 tasks
runspired
added
🏷️ test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/emberjs/ember.js/pull/19379/files
close #7439