Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] rollup step should deactivate ember modules polyfill >= 3.27 #7527

Merged
merged 5 commits into from
May 19, 2021
Merged

[BUGFIX] rollup step should deactivate ember modules polyfill >= 3.27 #7527

merged 5 commits into from
May 19, 2021

Conversation

runspired
Copy link
Contributor

@runspired runspired commented May 19, 2021 •
edited
Loading

fixes #7524

@runspired runspired added backport-beta PR targets the beta branch backport-lts PR targets the current lts branch backport-release PR targets the current release branch labels May 19, 2021
@github-actions
Copy link

github-actions bot commented May 19, 2021 •
edited
Loading

Asset Size Report for 9313310

IE11 Builds

✅ EmberData shrank by -2.23 KB (-506.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData +196.97 KB -2.23 KB (+40.23 KB -506.0 B compressed)
    @ember-data/adapter +17.37 KB -1.11 KB (+3.55 KB -251.01 B compressed)
        @ember-data/adapter/rest +8.72 KB -606.0 B (+1.78 KB -134.14 B compressed)
        @ember-data/adapter/index +1.55 KB -264.0 B (+323.89 B -58.44 B compressed)
        @ember-data/adapter/json-api +1.35 KB -264.0 B (+281.41 B -58.44 B compressed)
    ember-inflector +7.03 KB -1.13 KB (+1.44 KB -254.99 B compressed)
        ember-inflector/lib/helpers/pluralize +506.0 B -1.13 KB (+103.33 B -254.99 B compressed)
Full Asset Analysis (IE11) 

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '196.97 KB' │
│ compressed │ '40.23 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '81.51 KB' │
│  compressed  │ '16.65 KB' │
│ % Of Library │   '41.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 80.60 KB  | 16.46 KB   | 98.9          | 40.9
	@ember-data/store/index                           | 936.00 B  | 191.15 B   | 1.1           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '32.91 KB' │
│  compressed  │ '6.72 KB'  │
│ % Of Library │   '16.7'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 32.43 KB  | 6.62 KB    | 98.6          | 16.5
	@ember-data/model/index                           | 486.00 B  | 99.25 B    | 1.4           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '25.14 KB' │
│  compressed  │ '5.13 KB'  │
│ % Of Library │   '12.8'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 25.14 KB  | 5.13 KB    | 100.0         | 12.8

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '20.82 KB' │
│  compressed  │ '4.25 KB'  │
│ % Of Library │   '10.6'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.75 KB   | 1.58 KB    | 37.2          | 3.9
	@ember-data/serializer/-private                   | 5.69 KB   | 1.16 KB    | 27.3          | 2.9
	@ember-data/serializer/json-api                   | 3.92 KB   | 820.76 B   | 18.9          | 2.0
	@ember-data/serializer/rest                       | 3.00 KB   | 626.54 B   | 14.4          | 1.5
	@ember-data/serializer/index                      | 258.00 B  | 52.68 B    | 1.2           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 43.90 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '17.37 KB' │
│  compressed  │ '3.55 KB'  │
│ % Of Library │   '8.8'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 8.72 KB   | 1.78 KB    | 50.2          | 4.4
	@ember-data/adapter/-private                      | 3.80 KB   | 795.64 B   | 21.9          | 1.9
	@ember-data/adapter/error                         | 1.95 KB   | 407.21 B   | 11.2          | 1.0
	@ember-data/adapter/index                         | 1.55 KB   | 323.89 B   | 8.9           | 0.8
	@ember-data/adapter/json-api                      | 1.35 KB   | 281.41 B   | 7.7           | 0.7

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.24 KB' │
│  compressed  │ '1.89 KB' │
│ % Of Library │   '4.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.32 KB   | 485.84 B   | 25.1          | 1.2
	ember-data/-private                               | 1.98 KB   | 414.36 B   | 21.4          | 1.0
	ember-data/adapters/errors                        | 1.19 KB   | 248.53 B   | 12.9          | 0.6
	ember-data/setup-container                        | 503.00 B  | 102.72 B   | 5.3           | 0.2
	ember-data/relationships                          | 318.00 B  | 64.94 B    | 3.4           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 55.95 B    | 2.9           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 51.25 B    | 2.7           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 50.03 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 49.62 B    | 2.6           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 49.62 B    | 2.6           | 0.1
	ember-data/transform                              | 241.00 B  | 49.21 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 48.40 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 47.37 B    | 2.5           | 0.1
	ember-data/adapter                                | 226.00 B  | 46.15 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 45.33 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 45.33 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 44.52 B    | 2.3           | 0.1
	ember-data/version                                | 162.00 B  | 33.08 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.03 KB' │
│  compressed  │ '1.44 KB' │
│ % Of Library │   '3.6'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.11 KB   | 650.23 B   | 44.2          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 332.26 B   | 22.6          | 0.8
	ember-inflector/lib/helpers/pluralize             | 506.00 B  | 103.33 B   | 7.0           | 0.3
	ember-inflector/index                             | 473.00 B  | 96.59 B    | 6.6           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 96.18 B    | 6.5           | 0.2
	ember-inflector/lib/system/string                 | 332.00 B  | 67.80 B    | 4.6           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 62.89 B    | 4.3           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 60.44 B    | 4.1           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.96 KB'  │
│  compressed  │ '618.99 B' │
│ % Of Library │   '1.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.47 KB   | 516.88 B   | 83.5          | 1.3
	@ember-data/debug/setup                           | 500.00 B  | 102.10 B   | 16.5          | 0.2

Modern Builds

✅ EmberData shrank by -342.0 B (-124.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData +178.12 KB -342.0 B (+38.62 KB -124.0 B compressed)
    @ember-data/adapter +15.69 KB -342.0 B (+3.4 KB -124.0 B compressed)
        @ember-data/adapter/rest +8.03 KB -342.0 B (+1.74 KB -124.0 B compressed)
Full Asset Analysis (Modern) 

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '178.12 KB' │
│ compressed │ '38.62 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '72.01 KB' │
│  compressed  │ '15.61 KB' │
│ % Of Library │   '40.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 71.09 KB  | 15.42 KB   | 98.7          | 39.9
	@ember-data/store/index                           | 936.00 B  | 202.97 B   | 1.3           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '29.28 KB' │
│  compressed  │ '6.35 KB'  │
│ % Of Library │   '16.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 28.81 KB  | 6.25 KB    | 98.4          | 16.2
	@ember-data/model/index                           | 486.00 B  | 105.38 B   | 1.6           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '23.20 KB' │
│  compressed  │ '5.03 KB'  │
│ % Of Library │   '13.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 23.20 KB  | 5.03 KB    | 100.0         | 13.0

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.34 KB' │
│  compressed  │ '4.19 KB'  │
│ % Of Library │   '10.9'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.12 KB   | 1.54 KB    | 36.8          | 4.0
	@ember-data/serializer/-private                   | 5.37 KB   | 1.16 KB    | 27.8          | 3.0
	@ember-data/serializer/json-api                   | 3.69 KB   | 820.12 B   | 19.1          | 2.1
	@ember-data/serializer/rest                       | 2.71 KB   | 602.40 B   | 14.0          | 1.5
	@ember-data/serializer/index                      | 243.00 B  | 52.69 B    | 1.2           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 46.62 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.69 KB' │
│  compressed  │ '3.40 KB'  │
│ % Of Library │   '8.8'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 8.03 KB   | 1.74 KB    | 51.2          | 4.5
	@ember-data/adapter/-private                      | 3.58 KB   | 795.83 B   | 22.8          | 2.0
	@ember-data/adapter/error                         | 1.91 KB   | 424.80 B   | 12.2          | 1.1
	@ember-data/adapter/index                         | 1.14 KB   | 252.41 B   | 7.2           | 0.6
	@ember-data/adapter/json-api                      | 1.02 KB   | 226.17 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.24 KB' │
│  compressed  │ '2.00 KB' │
│ % Of Library │   '5.2'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.32 KB   | 515.88 B   | 25.1          | 1.3
	ember-data/-private                               | 1.98 KB   | 439.98 B   | 21.4          | 1.1
	ember-data/adapters/errors                        | 1.19 KB   | 263.90 B   | 12.9          | 0.7
	ember-data/setup-container                        | 503.00 B  | 109.07 B   | 5.3           | 0.3
	ember-data/relationships                          | 318.00 B  | 68.95 B    | 3.4           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 59.41 B    | 2.9           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 54.42 B    | 2.7           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 53.12 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 52.69 B    | 2.6           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 52.69 B    | 2.6           | 0.1
	ember-data/transform                              | 241.00 B  | 52.26 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 51.39 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 50.30 B    | 2.5           | 0.1
	ember-data/adapter                                | 226.00 B  | 49.00 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 48.14 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 48.14 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 47.27 B    | 2.3           | 0.1
	ember-data/version                                | 162.00 B  | 35.12 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.66 KB' │
│  compressed  │ '1.44 KB' │
│ % Of Library │   '3.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.88 KB   | 639.48 B   | 43.3          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 352.81 B   | 23.9          | 0.9
	ember-inflector/index                             | 473.00 B  | 102.56 B   | 6.9           | 0.3
	ember-inflector/lib/system                        | 471.00 B  | 102.13 B   | 6.9           | 0.3
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 80.88 B    | 5.5           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 68.95 B    | 4.7           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 66.78 B    | 4.5           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 64.18 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.70 KB'  │
│  compressed  │ '599.58 B' │
│ % Of Library │   '1.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.21 KB   | 491.37 B   | 82.0          | 1.2
	@ember-data/debug/setup                           | 499.00 B  | 108.20 B   | 18.0          | 0.3

Modern Builds (No Rollup)

✅ EmberData shrank by -957.0 B (-212.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData +217.15 KB -957.0 B (+41.85 KB -212.0 B compressed)
    @ember-data/model +33.25 KB -615.0 B (+6.41 KB -136.24 B compressed)
        @ember-data/model/-private/model +9.86 KB -127.0 B (+1.9 KB -28.13 B compressed)
        @ember-data/model/-private/record-state +6.18 KB -226.0 B (+1.19 KB -50.06 B compressed)
        @ember-data/model/-private/system/promise-many-array +3.82 KB -262.0 B (+753.96 B -58.04 B compressed)
    @ember-data/adapter +17.8 KB -342.0 B (+3.43 KB -75.76 B compressed)
        @ember-data/adapter/rest +8.03 KB -342.0 B (+1.55 KB -75.76 B compressed)
Full Asset Analysis (Modern) 

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '217.15 KB' │
│ compressed │ '41.85 KB'  │
│  packages  │      8      │
│  modules   │     149     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '95.53 KB' │
│  compressed  │ '18.41 KB' │
│ % Of Library │   '44.0'   │
└──────────────┴────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 17.10 KB  | 3.30 KB    | 17.9          | 7.9
	@ember-data/store/-private/system/model/internal-model                             | 14.33 KB  | 2.76 KB    | 15.0          | 6.6
	@ember-data/store/-private/system/model/states                                     | 5.42 KB   | 1.04 KB    | 5.7           | 2.5
	@ember-data/store/-private/system/fetch-manager                                    | 5.00 KB   | 986.40 B   | 5.2           | 2.3
	@ember-data/store/-private/system/store/finders                                    | 4.49 KB   | 885.60 B   | 4.7           | 2.1
	@ember-data/store/-private/system/record-array-manager                             | 4.11 KB   | 811.20 B   | 4.3           | 1.9
	@ember-data/store/-private/identifiers/cache                                       | 3.88 KB   | 764.95 B   | 4.1           | 1.8
	@ember-data/store/-private/index                                                   | 3.57 KB   | 704.43 B   | 3.7           | 1.6
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.36 KB   | 662.80 B   | 3.5           | 1.5
	@ember-data/store/-private/system/snapshot                                         | 3.21 KB   | 632.73 B   | 3.4           | 1.5
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.91 KB   | 575.11 B   | 3.1           | 1.3
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.25 KB   | 443.86 B   | 2.4           | 1.0
	@ember-data/store/-private/system/request-cache                                    | 1.89 KB   | 372.16 B   | 2.0           | 0.9
	@ember-data/store/-private/system/ds-model-store                                   | 1.85 KB   | 365.80 B   | 1.9           | 0.9
	@ember-data/store/-private/system/references/has-many                              | 1.53 KB   | 301.81 B   | 1.6           | 0.7
	@ember-data/store/-private/system/schema-definition-service                        | 1.47 KB   | 290.83 B   | 1.5           | 0.7
	@ember-data/store/-private/system/model/shim-model-class                           | 1.32 KB   | 259.99 B   | 1.4           | 0.6
	@ember-data/store/-private/system/references/belongs-to                            | 1.30 KB   | 257.10 B   | 1.4           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.12 KB   | 221.83 B   | 1.2           | 0.5
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 1.05 KB   | 207.76 B   | 1.1           | 0.5
	@ember-data/store/-private/system/references/record                                | 979.00 B  | 188.68 B   | 1.0           | 0.4
	@ember-data/store/index                                                            | 936.00 B  | 180.39 B   | 1.0           | 0.4
	@ember-data/store/-private/system/references/reference                             | 917.00 B  | 176.73 B   | 0.9           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 892.00 B  | 171.91 B   | 0.9           | 0.4
	@ember-data/store/-private/system/internal-model-map                               | 869.00 B  | 167.48 B   | 0.9           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 764.00 B  | 147.24 B   | 0.8           | 0.3
	@ember-data/store/-private/system/snapshot-record-array                            | 753.00 B  | 145.12 B   | 0.8           | 0.3
	@ember-data/store/-private/system/record-notification-manager                      | 697.00 B  | 134.33 B   | 0.7           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 115.25 B   | 0.6           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 556.00 B  | 107.15 B   | 0.6           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 506.00 B  | 97.52 B    | 0.5           | 0.2
	@ember-data/store/-private/system/store/common                                     | 505.00 B  | 97.32 B    | 0.5           | 0.2
	@ember-data/store/-private/system/coerce-id                                        | 496.00 B  | 95.59 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 93.86 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 450.00 B  | 86.72 B    | 0.5           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 400.00 B  | 77.09 B    | 0.4           | 0.2
	@ember-data/store/-private/utils/symbol                                            | 393.00 B  | 75.74 B    | 0.4           | 0.2
	@ember-data/store/-private/system/record-data-for                                  | 373.00 B  | 71.88 B    | 0.4           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 327.00 B  | 63.02 B    | 0.3           | 0.1
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 60.90 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 55.89 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 239.00 B  | 46.06 B    | 0.2           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 42.40 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.85 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 193.00 B  | 37.19 B    | 0.2           | 0.1
	@ember-data/store/-private/system/deprecated-evented                               | 190.00 B  | 36.61 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 98.00 B   | 18.88 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 96.00 B   | 18.50 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 95.00 B   | 18.30 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 95.00 B   | 18.30 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 95.00 B   | 18.30 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 90.00 B   | 17.34 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 89.00 B   | 17.15 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 89.00 B   | 17.15 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 85.00 B   | 16.38 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-instance                           | 85.00 B   | 16.38 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data                               | 81.00 B   | 15.61 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 78.00 B   | 15.03 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/utils                                     | 75.00 B   | 14.45 B    | 0.1           | 0.0

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '33.25 KB' │
│  compressed  │ '6.41 KB'  │
│ % Of Library │   '15.3'   │
└──────────────┴────────────┘
	Module                                                                | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                                      | 9.86 KB   | 1.90 KB    | 29.7          | 4.5
	@ember-data/model/-private/record-state                               | 6.18 KB   | 1.19 KB    | 18.6          | 2.8
	@ember-data/model/-private/system/promise-many-array                  | 3.82 KB   | 753.96 B   | 11.5          | 1.8
	@ember-data/model/-private/system/many-array                          | 2.78 KB   | 549.47 B   | 8.4           | 1.3
	@ember-data/model/-private/errors                                     | 2.03 KB   | 401.26 B   | 6.1           | 0.9
	@ember-data/model/-private/index                                      | 1.42 KB   | 280.61 B   | 4.3           | 0.7
	@ember-data/model/-private/system/relationships/relationship-meta     | 1.25 KB   | 247.27 B   | 3.8           | 0.6
	@ember-data/model/-private/tmp-cached-polyfill                        | 1000.00 B | 192.73 B   | 2.9           | 0.4
	@ember-data/model/-private/attr                                       | 823.00 B  | 158.61 B   | 2.4           | 0.4
	@ember-data/model/-private/notify-changes                             | 817.00 B  | 157.46 B   | 2.4           | 0.4
	@ember-data/model/-private/belongs-to                                 | 626.00 B  | 120.64 B   | 1.8           | 0.3
	@ember-data/model/-private/has-many                                   | 587.00 B  | 113.13 B   | 1.7           | 0.3
	@ember-data/model/index                                               | 486.00 B  | 93.66 B    | 1.4           | 0.2
	@ember-data/model/-private/util                                       | 442.00 B  | 85.18 B    | 1.3           | 0.2
	@ember-data/model/-private/system/diff-array                          | 438.00 B  | 84.41 B    | 1.3           | 0.2
	@ember-data/model/-private/system/promise-belongs-to                  | 412.00 B  | 79.40 B    | 1.2           | 0.2
	@ember-data/model/-private/system/model-for-mixin                     | 408.00 B  | 78.63 B    | 1.2           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '29.97 KB' │
│  compressed  │ '5.78 KB'  │
│ % Of Library │   '13.8'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 8.16 KB   | 1.57 KB    | 27.2          | 3.8
	@ember-data/record-data/-private/graph/index                                      | 4.61 KB   | 909.88 B   | 15.4          | 2.1
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.01 KB   | 593.61 B   | 10.0          | 1.4
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.81 KB   | 554.29 B   | 9.4           | 1.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 1.97 KB   | 389.12 B   | 6.6           | 0.9
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 1.90 KB   | 375.24 B   | 6.3           | 0.9
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.42 KB   | 279.65 B   | 4.7           | 0.7
	@ember-data/record-data/-private/graph/-utils                                     | 1.03 KB   | 203.90 B   | 3.4           | 0.5
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 979.00 B  | 188.68 B   | 3.2           | 0.4
	@ember-data/record-data/-private/index                                            | 977.00 B  | 188.29 B   | 3.2           | 0.4
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 771.00 B  | 148.59 B   | 2.5           | 0.3
	@ember-data/record-data/-private/relationships/state/implicit                     | 692.00 B  | 133.37 B   | 2.3           | 0.3
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 650.00 B  | 125.27 B   | 2.1           | 0.3
	@ember-data/record-data/-private/coerce-id                                        | 406.00 B  | 78.24 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 56.47 B    | 1.0           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.87 B    | 0.8           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data           | 100.00 B  | 19.27 B    | 0.3           | 0.0
	@ember-data/record-data/-private/graph/-operations                                | 79.00 B   | 15.22 B    | 0.3           | 0.0

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '21.74 KB' │
│  compressed  │ '4.19 KB'  │
│ % Of Library │   '10.0'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.12 KB   | 1.37 KB    | 32.7          | 3.3
	@ember-data/serializer/-private/embedded-records-mixin     | 4.30 KB   | 848.40 B   | 19.8          | 2.0
	@ember-data/serializer/json-api                            | 3.69 KB   | 728.90 B   | 17.0          | 1.7
	@ember-data/serializer/rest                                | 2.71 KB   | 535.40 B   | 12.5          | 1.2
	@ember-data/serializer/-private/index                      | 1.18 KB   | 233.20 B   | 5.4           | 0.5
	@ember-data/serializer/-private/transforms/date            | 523.00 B  | 100.79 B   | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/boolean         | 490.00 B  | 94.43 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 446.00 B  | 85.95 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 351.00 B  | 67.64 B    | 1.6           | 0.2
	@ember-data/serializer/-private/utils                      | 286.00 B  | 55.12 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 243.00 B  | 46.83 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 242.00 B  | 46.64 B    | 1.1           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 41.43 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '17.80 KB' │
│  compressed  │ '3.43 KB'  │
│ % Of Library │   '8.2'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 8.03 KB   | 1.55 KB    | 45.1          | 3.7
	@ember-data/adapter/error                                     | 1.91 KB   | 377.56 B   | 10.7          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.82 KB   | 359.82 B   | 10.2          | 0.8
	@ember-data/adapter/index                                     | 1.14 KB   | 224.33 B   | 6.4           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 203.52 B   | 5.8           | 0.5
	@ember-data/adapter/json-api                                  | 1.02 KB   | 201.01 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 792.00 B  | 152.64 B   | 4.3           | 0.4
	@ember-data/adapter/-private/utils/determine-body-promise     | 549.00 B  | 105.80 B   | 3.0           | 0.2
	@ember-data/adapter/-private/utils/parse-response-headers     | 480.00 B  | 92.51 B    | 2.6           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 87.50 B    | 2.5           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 347.00 B  | 66.87 B    | 1.9           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 219.00 B  | 42.20 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 76.00 B   | 14.64 B    | 0.4           | 0.0

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.50 KB' │
│  compressed  │ '1.83 KB' │
│ % Of Library │   '4.4'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.32 KB   | 458.50 B   | 24.5          | 1.1
	ember-data/-private/index                         | 1.93 KB   | 380.45 B   | 20.3          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 234.55 B   | 12.5          | 0.5
	ember-data/setup-container                        | 503.00 B  | 96.94 B    | 5.2           | 0.2
	ember-data/-private/core                          | 321.00 B  | 61.86 B    | 3.3           | 0.1
	ember-data/relationships                          | 318.00 B  | 61.28 B    | 3.3           | 0.1
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.80 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 48.37 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 47.21 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.83 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.83 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 46.44 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.67 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.71 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.55 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 42.78 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 42.78 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 42.01 B    | 2.2           | 0.1
	ember-data/version                                | 162.00 B  | 31.22 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.66 KB' │
│  compressed  │ '1.28 KB' │
│ % Of Library │   '3.1'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.88 KB   | 568.36 B   | 43.3          | 1.3
	ember-inflector/lib/system/inflections            | 1.59 KB   | 313.57 B   | 23.9          | 0.7
	ember-inflector/index                             | 473.00 B  | 91.16 B    | 6.9           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 90.77 B    | 6.9           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 71.88 B    | 5.5           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 61.28 B    | 4.7           | 0.1
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 59.36 B    | 4.5           | 0.1
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 57.04 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.70 KB'  │
│  compressed  │ '532.90 B' │
│ % Of Library │   '1.2'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.21 KB   | 436.72 B   | 82.0          | 1.0
	@ember-data/debug/setup                           | 499.00 B  | 96.17 B    | 18.0          | 0.2

@github-actions
Copy link

github-actions bot commented May 19, 2021 •
edited
Loading

Performance Report for 9313310

Scenario - materialization: ✅ Performance improved

✅ duration
phase estimated improvement -20ms [-40ms to -1ms] OR -0.93% [-1.88% to -0.05%]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-13ms to 10ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-14ms to 14ms]
✅ Phase [start-materialization] => [end-materialization]
phase estimated improvement -17ms [-25ms to -8ms] OR -2.22% [-3.32% to -1.1%]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-6ms to 1ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-13ms to 56ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-9ms to 14ms]
⚠️ Phase [start-push-payload] => [start-unload-records]
phase estimated regression +26ms [6ms to 48ms] OR +1.75% [0.43% to 3.24%]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-15ms to 4ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [-2ms to 1ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-38ms to 32ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-14ms to 7ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-30ms to 12ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-9ms to 19ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-13ms to 25ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-12ms to 16ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-3ms to 17ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-1ms to 8ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [-3ms to 1ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-32ms to 25ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-16ms to 12ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-21ms to 15ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [-1ms to 3ms]

@runspired runspired merged commit c67237b into master May 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/rollup-config-modules-api branch May 19, 2021 04:07
@runspired runspired added the 🏷️ bug This PR primarily fixes a reported issue label May 26, 2021
runspired added a commit that referenced this pull request May 26, 2021
@runspired
[BUGFIX] rollup step should deactivate ember modules polyfill >= 3.27 (…
af58229 
…#7527)

* disable modules polyfills when transpiling for rollup

* implement fix

* fix lint

* fix expansion

* better comment
@runspired runspired added 🎯 beta PR should be backported to beta 🎯 lts The PR should be backported to the most recent LTS 🎯 release PR should be backported to release and removed backport-beta PR targets the beta branch backport-lts PR targets the current lts branch backport-release PR targets the current release branch labels May 26, 2021
@runspired runspired mentioned this pull request May 26, 2021
Merged
runspired added a commit that referenced this pull request May 26, 2021
@runspired
[BUGFIX release] rollup step should deactivate ember modules polyfill…
6a88c7c 
… >= 3.27 (#7552)

* [BUGFIX] rollup step should deactivate ember modules polyfill >= 3.27 (#7527)

* disable modules polyfills when transpiling for rollup

* implement fix

* fix lint

* fix expansion

* better comment

* fix lint
@runspired runspired removed the 🎯 beta PR should be backported to beta label May 27, 2021
@rwjblue rwjblue mentioned this pull request May 28, 2021
Closed
@ijlee2 ijlee2 mentioned this pull request Aug 31, 2021
Merged
40 tasks
@igorT igorT removed the 🎯 release PR should be backported to release label Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer approved these changes

@rwjblue rwjblue Awaiting requested review from rwjblue

Assignees
No one assigned
Labels
🎯 lts The PR should be backported to the most recent LTS 🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DEPRECATION: Usage of the Ember Global is deprecated
3 participants
@runspired @snewcomer @igorT