schedule watchTypeIfUnseen to prevent loop

[patricklx]

fixes #8006

[patricklx]

could also fix emberjs/ember-inspector#1875

[kdagnan]

@patricklx I was having a similar issue & stack trace to you - but I just tried running your branch locally and it hasn't fixed anything for me. Funny enough it's on a regex call. Do you think you could look at this one? Might be a quick/similar fix.
Uncaught (in promise) RangeError: Maximum call stack size exceeded at RegExp.exec (<anonymous>) at RegExp.test (<anonymous>) at isBlank (index.js:2729:1) at Object.isPresent (index.js:2768:1) at Store.modelFor (-private.js:10613:1) at Class.watchTypeIfUnseen (index.js:105:1) at store._createRecordData (index.js:69:1) at get _recordData [as _recordData] (-private.js:4989:1) at InternalModel._isRecordFullyDeleted (-private.js:5024:1) at InternalModel.isHiddenFromRecordArrays (-private.js:5018:1)

[patricklx]

I think that's something else. You can get a Maximum call stack size exceeded with the regex.test alone as well if its on a strange string. At least i do not see a loop there

[snewcomer]

@patricklx Would you mind adding a test if applicable to save-test.js?

[patricklx]

@snewcomer i changed the debug-adapter-test to use createRecord. This will cause the test to fail, but work with the fix i provide.
since the update call is now delayed, it will also include the newly created record in the count, and no updates

[kdagnan]

Can confirm this fix addressed similar loop issues for me. Originally it did not because I was running ember 3.28, ember-data 4.4 (your branch), and ember-cli 4.2.0. Updating ember-cli to 4.4.0 and manually adding your fix to the NPM-installed ember-data 3.28.10 fixed this issue.

Could we get this applied to a 3.28.11 as well? :)

[spruce]

This fixes #8006 for me

[runspired]

@patricklx looks like the tests fail, mind rebasing and looking into that?

[brandensilva]

I would also appreciate a 3.28.11 release on this one. It had me scratching my head for half a day wondering how my typescript upgrades were call stacking and triggering illegal character issues. Thanks for fixing this @patricklx!

[runspired]

@brandensilva in the works