Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember addons that use babel plugins cannot be developed on using npm link or yarn link #233

Open
Duder-onomy opened this issue Jul 26, 2018 · 2 comments

Comments

@Duder-onomy
Copy link

(please let me know if this belongs somewhere else)

When I attempt to work on a ember addon by yarn link or npm link babel cannot resolve plugins.

Steps to reproduce:

  • ember new
  • git clone a ember addon with babel plugins ( ember-cli-imgix uses babel plugins ) git clone git@github.com:imgix/ember-cli-imgix.git
  • run npm link in the addons dir.
  • run npm link <addon name> in the newly created ember app.
  • run ember serve

Observe that ember cannot resolve the babel plugins.

My feeling is that it has something to do with: babel/babel-loader#149 (comment)
But I really don't know.

You might see something like:
image

My current workaround is to push the addon and consume it by commit hash.


Output from ember version --verbose && npm --version && yarn --version:

ember-cli: 3.0.4
http_parser: 2.8.0
node: 8.11.3
v8: 6.2.414.54
uv: 1.19.1
zlib: 1.2.11
ares: 1.10.1-DEV
modules: 57
nghttp2: 1.32.0
napi: 3
openssl: 1.0.2o
icu: 60.1
unicode: 10.0
cldr: 32.0
tz: 2017c
os: darwin x64
5.6.0
1.7.0
@rwjblue
Copy link
Member

rwjblue commented Jul 27, 2018

@lukemelia is this the same basic issue that you were mentioning to me tonight after Ember NYC?

@lukemelia
Copy link
Member

@rwjblue the repro steps match; the specific error that I saw is different, but it was on ember-cli 2.18. I'm not sure if it is triggered by addons with babel plugins, but that is certainly possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants