Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explore removing sync XHR #820

Closed
stefanpenner opened this issue Jun 6, 2018 · 1 comment
Closed

explore removing sync XHR #820

stefanpenner opened this issue Jun 6, 2018 · 1 comment
Assignees

Comments

@stefanpenner
Copy link
Member

this one:

xhr.open("GET", chrome.runtime.getURL(`/panes-${minimumVersion}/ember_debug.js`), false);

more context: #817

I'm not 100% sure if it is possible to remove this sync XHR, but potentially it could be done in an initializer and defer/advance readiness?

The code in question was added way back in 2013: de62bd6

It is possible this is required, to win some race. but lets ask @teddyzeenny

@teddyzeenny
Copy link
Contributor

This was added in the third ever commit to the inspector. I'm not entirely sure what the reason was for making it sync, but nothing comes to mind as to why async xhr wouldn't work. We can try it.

@RobbieTheWagner RobbieTheWagner self-assigned this Jul 26, 2018
RobbieTheWagner added a commit that referenced this issue Jul 26, 2018
RobbieTheWagner added a commit that referenced this issue Jul 27, 2018
* Convert to async xhr

Resolves #820

* Move load outside forEach
cyril-sf pushed a commit to cyril-sf/ember-inspector that referenced this issue Mar 30, 2022
* Convert to async xhr

Resolves emberjs#820

* Move load outside forEach
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants