Convert to async xhr #839
Merged
Convert to async xhr #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #820
|
Q: now that this is async, is there any waiting / coordinating we must do, to mitigate potential race conditions? |
|
@stefanpenner I'm not sure. I wrapped in a promise and made sure to wait for the promise to resolve before using the returned values, and everything seemed to work locally for me. I think it should work okay. |
|
@teddyzeenny mind taking a 馃憖 |
teddyzeenny
approved these changes
Jul 27, 2018
app/adapters/web-extension.js
Outdated
| }, | ||
|
|
||
| canOpenResource: false, | ||
|
|
||
| sendIframes(urls) { | ||
| urls.forEach(url => { | ||
| chrome.devtools.inspectedWindow.eval(loadEmberDebug(), { frameURL: url }); | ||
| loadEmberDebug().then((emberDebug) => { |
There was a problem hiding this comment.
You can load Ember Debug once and call the forEach inside then.
cyril-sf
pushed a commit
to cyril-sf/ember-inspector
that referenced
this pull request
Mar 30, 2022
* Convert to async xhr Resolves emberjs#820 * Move load outside forEach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #820
I think this should do the trick, but would love some eyes on this to let me know if I did anything dumb 馃槃