Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<LinkTo> #1045

Merged
merged 2 commits into from
Oct 2, 2019
Merged

<LinkTo> #1045

merged 2 commits into from
Oct 2, 2019

Conversation

nummi
Copy link
Collaborator

@nummi nummi commented Oct 2, 2019

No description provided.

@@ -1,63 +0,0 @@
<nav class="nav nav--main">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this file just a duplicate? Never used?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was left over from 412dc4b. Before that commit we had {{partial "nav"}} which rendered this file, but I think after that commit this file was unused completely.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. 👍

@@ -1,63 +0,0 @@
<nav class="nav nav--main">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was left over from 412dc4b. Before that commit we had {{partial "nav"}} which rendered this file, but I think after that commit this file was unused completely.

@nummi nummi merged commit 6f0a5d4 into emberjs:master Oct 2, 2019
@nummi nummi deleted the LinkTo branch October 2, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants