-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor StorageService
#1095
Refactor StorageService
#1095
Conversation
4d4eb4c
to
3c92953
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay to me. I wasn't really aware of any of this stuff, so fi you say it works, good enough for me 👍
3c92953
to
e55192e
Compare
@rwwagner90 The primary difference is that it used to be that everywhere we want to inject the service, we need to be careful to inject the "right" backend, but now there is an extra indirection (the "storage" service) to select the "right" backend once, then everywhere else we can just use it as usual. I also fixed some minor bugs regarding how |
Not sure why the linter wasn't catching it before and suddenly start to care, but it flagged a few "no-new-mixins" violations 🤔 |
Ensure we are always using the in-memory storage service backend in tests, so that we aren't leaking test states into local storage, or otherwise change test behaviors due to existing items there.
db89d41
to
91aa675
Compare
@chancancode looks like this is passing now. Should we merge? |
Yes 😄 |
Ensure we are always using the in-memory storage service backend in tests, so that we aren't leaking test states into local storage, or otherwise change test behaviors due to existing items there.
Ensure we are always using the in-memory storage service backend in tests, so that we aren't leaking test states into local storage, or otherwise change test behaviors due to existing items there.
Ensure we are always using the in-memory storage service backend in tests, so that we aren't leaking test states into local storage, or otherwise change test behaviors due to existing items there.
Ensure we are always using the in-memory storage service backend in tests, so that we aren't leaking test states into local storage, or otherwise change test behaviors due to existing items there.