Co-locate component templates #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chancancode IIRC, I had several things colocated, and you moved them to not be. Do you recall why? |
|
Don't think so! You may be remembering that we moved the in-repo addon in #1057, which caused some problems, and we talked about reverting it in #1101, but in the end we decided that was not necessary, and did #1102 instead. As far as I can tell, we just never did it in the app folder but I could be missing something. |
RobbieTheWagner
approved these changes
Apr 1, 2020
rwjblue
approved these changes
Apr 2, 2020
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't remember if there was a reason we didn't do this already. Seems like it should just work, and IIRC #1102 should have already fixed any accidental problems.