Reset internal test helper state for EmberDebug tests. #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change we could not run any tests that leveraged the `@ember/test-helpers` setup methods that ran _after_ the files in `tests/ember_debug/**/*-test.js`. This was because the `setupEIApp`/`destroyEIApp` helper functions would call `setApplication` (to get a pristine state for their own tests), but would not clean up after themselves (calling `setApplication` with the original value). This change is a minimal patch to fix the fundamental issue (and adding a single integration test to the mix to ensure it doesn't regress), but a larger refactor is in order to simplify these setupEI/destroyEI test helpers.
3 tasks
RobbieTheWagner
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change we could not run any tests that leveraged the
@ember/test-helperssetup methods that ran after the files intests/ember_debug/**/*-test.js. This was because thesetupEIApp/destroyEIApphelper functions would callsetApplication(to get a pristine state for their own tests), but would not clean up after themselves (callingsetApplicationwith the original value).This change is a minimal patch to fix the fundamental issue (and adding a single integration test to the mix to ensure it doesn't regress), but a larger refactor is in order to simplify these setupEI/destroyEI test helpers.
Related to #1201