Components Inside an Each Added to View Tree #428
Conversation
This should address emberjs#365, where components inside an {{#each}} are not inspected.
atsjj
changed the title
|
So, I am getting some odd behavior while inspecting and using my app at the same time. I decided to throw a [WIP] tag in the PR, because this is no where near ready to merge. |
|
This sees to work fine, and the code looks good to me. What kind of problems were you seeing? |
| * @return {Array} children | ||
| */ | ||
| _childrenForNode(renderNode) { | ||
| if (!!renderNode.morphMap) { |
There was a problem hiding this comment.
This is causing the linting failure (and subsequently the CI failure). Changing to:
if (renderNode.morphMap) { }Should fix.
|
Sorry for the delay; busy week! @ef4 the problem I'm having is when inspecting an object, it seems the bindings get all screwed up. I haven't had much time to get back into this, but try inspecting a route or controller and then trigger a transition to another route. That's where I was running into this problem. |
|
@ef4 I can't reproduce the error any longer and everything is working as I'd expect. |
atsjj
changed the title
Components Inside an Each Added to View Tree
|
This is great! Thank you! When will this be published to Chrome extension? |
This should address #365, where components inside an {{#each}} are not
inspected.
Feedback on this is greatly appreciated!