Prevent errors when document.documentElement.dataset is not present. #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@teddyzeenny - Should be ready for review... |
| (document.documentElement && !document.documentElement.dataset) || | ||
|
|
||
| // when the content script is loaded, this flag is set to `1` | ||
| document.documentElement.dataset.emberExtensions |
There was a problem hiding this comment.
This code wouldn't execute if it's not an Ember app.
There was a problem hiding this comment.
Ok, so you are saying that we do not need to guard here?
rwjblue
force-pushed
the
prevent-missing-dataset-from-erroring
branch
from
1be5d0b
to
a0dc523
Compare
| // let ember-debug know that content script has executed | ||
| document.documentElement.dataset.emberExtension = 1; | ||
| // document.documentElement.dataset is not present for SVG elements | ||
| // this guard (and a corresponding one in ember-debug/adapters/basic) |
There was a problem hiding this comment.
can you update the comment?
if `document.documentElement` does not have a `dataset` property we will never mark the content script as loaded (and it cannot be an Ember app) this happens in some scenarios with Chrome 45+ and SVG elements.
rwjblue
force-pushed
the
prevent-missing-dataset-from-erroring
branch
from
a0dc523
to
89c9c86
Compare
teddyzeenny
added a commit
that referenced
this pull request
Oct 1, 2015
…oring Prevent errors when document.documentElement.dataset is not present.
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
document.documentElementdoes not have adatasetproperty we will never mark the content script as loaded (and it cannot be an Ember app) this happens in some scenarios with Chrome 45+ and SVG elements.Fixes #463
Closes #473