Upgraded to ember 1.12.0 #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We chatted a bit about this in slack, and I think we decided that the extraction of I think that @patsy-issa is going to change that back (and confirm the tests still pass). |
|
c changing back and adding comments to the files. |
patsy-issa
force-pushed
the
upgrade-ember
branch
2 times, most recently
from
836a737
to
cde12be
Compare
|
Looks good to me. @teddyzeenny - r? |
| mouseEnter(e) { | ||
| this.get('controller').send('previewLayer', this.get('node')); | ||
| e.stopPropagation(); | ||
| }, | ||
|
|
||
| /** | ||
| * @property mouseLeave |
patsy-issa
force-pushed
the
upgrade-ember
branch
2 times, most recently
from
f9afd68
to
c436c9f
Compare
|
Can you remove "Moved required properties into list-view mixin" from the commit message? |
Upgraded ember list view to v 0.0.6 Added SafeString to style bindings Part of emberjs#360
patsy-issa
force-pushed
the
upgrade-ember
branch
from
c436c9f
to
524afb5
Compare
|
Updated commit message and added |
|
🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded ember list view to v 0.0.6
Added SafeString to style bindings
Part of #360