Ember 3.0, dep updates, testing updates, and codemods #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had an issue with controller._controller.
It was used with EventRow mixin
teddyzeenny
approved these changes
Mar 3, 2018
| // _just_ to determine if it was a function | ||
| let descriptor = meta.peekDescriptors(prop); | ||
| if (descriptor) { | ||
| continue; |
| @@ -221,8 +220,9 @@ export default EmberObject.extend(PortMixin, { | |||
| if (this.glimmerTree) { | |||
| this.glimmerTree.highlightLayer(viewElem.id); | |||
| } else { | |||
| this.highlightView(viewElem[0]); | |||
| this.highlightView(viewElem); | |||
cyril-sf
pushed a commit
to cyril-sf/ember-inspector
that referenced
this pull request
Mar 30, 2022
* Bump some deps * Remove manual sass and lint * First pass at ember 3 * Fix the first container test * Convert to ember-test-helpers * Use vertical-collection * Use positional param for VC * Fix some lint issues * Fix the view tree * Add trs with classes * Add imports for wait helper * Fix class * WIP * Remove usage of container-instance for simple action case. * Fix acceptance test to use `find` / `findAll` without "context" element. * Tweak ember debug tests to use newer ember testing setup.. * Fix a bunch of tests * Remove unused container-instance component * Fix more tests, use location: none * Fix rootElement and binding tests * Fix some missed __container__ * Lint ember_debug * Fix getClassName resolver * Add ember-try * Filter ember-try to only test ember_debug * Attempt to use stages * Try to fix stages * Try another env * Try matrix * Adjust matrix more * Add missing : * Fix indent lint * fail_fast: false so we can see all test results * Travis tweaks * Move script to stage * Maybe fix stage? * Remove stages config, set script back to global * Since stages do not proceed if the previous fails, switch them * Bump ember-try, fix owner.factoryFor * Restrict to master for builds * Try skip cleanup * Try to fix some hover issues * Test with more ember versions * Use short name for view * Use Ember.Component instead of Ember.View * Use controller.controller We had an issue with controller._controller. * Super hacky workaround for 2.10 * Work around computed issues in 3.1+ tests * Fix lint issues * Fix calculating computeds, cleanup TODOs * Remove RowEventsMixin, move actions to trs * Update yarn commands * Fix view preview layer test * Revert preview layer changes * Revert previews, fix tests * Remove the index property It was used with EventRow mixin * Remove ember-math-helpers * Confirm removal of eslint test generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did a lot of work here to update things to newer standards and fix the usages of the
__container__private API to usethis.ownerAPI. We also convertedember-native-dom-helperscode to@ember/test-helperscode, removed some dead code and wrote our own custom logic in test helpers to setup and destroy the app.We still have one failing test, but there is a lot to review here, so I wanted to get it up for people to review while we poke at the one remaining failure. Thanks to @rwjblue and @teddyzeenny for their extensive help figuring out some of the issues I encountered!