Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "info" nav title #935

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

nlfurniss
Copy link
Contributor

@nlfurniss nlfurniss commented Jan 31, 2019

This is a very low priority, but maybe I'm not the only one who find the Info heading hard to distinguish from the links underneath. It also doesn't add anything, as the user can already see that Info is highlighted in the left menu.

EDIT: on second thought, maybe the answer is to bold the nav title or give it a border bottom

screen shot 2019-01-30 at 10 20 46 pm

If you disagree, feel free to close 😊

@RobbieTheWagner
Copy link
Member

Removing is fine with me. Thoughts @nummi?

@nummi
Copy link
Collaborator

nummi commented Jan 31, 2019

Fine with me. I do intend to bold the headings in the future but in this case the heading feels redundant.

image

image

@RobbieTheWagner RobbieTheWagner merged commit a31c214 into emberjs:master Jan 31, 2019
@nlfurniss nlfurniss deleted the remove-info-header branch March 12, 2019 02:26
cyril-sf pushed a commit to cyril-sf/ember-inspector that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants