Allow addon to provide jQuery to final build, but not include Ember <-> jQuery integration.

[lupestro]

Using a this.$() with explicit jquery-integration: false now invokes the code in emberjs proper. However, that emberjs code throws an assertion rather than displaying a deprecation when it detects the feature is disabled.

I'm of two minds whether this is appropriate. If it was an assertion because the flag indicated that jQuery would be absent so the call would fail anyway, it was only appropriate while the flag was closely coupled to the presence/absence of the package. If it interprets the explicit flag as saying, "As far as Ember is concerned, jQuery is no longer here," it might be quite appropriate.

I'm perfectly happy to leave this to wiser heads to sort out and implement what they recommend. One possibility is to provide an alternate implementation of component.dollar.js in this case that still applies the deprecation, but, knowing the jquery is present, doesn't resort to the assertion.

[lupestro]

For reference, the code on the emberjs side is in: https://github.com/emberjs/ember.js/blob/bc435eb0a11868f7e0f8381f9a4bb2ba7728d9e8/packages/%40ember/-internals/views/lib/mixins/view_support.js#L438

[rwjblue]

Using a this.$() with explicit jquery-integration: false now invokes the code in emberjs proper. However, that emberjs code throws an assertion rather than displaying a deprecation when it detects the feature is disabled.

This seems intentional. Specifying jquery-integration: false specifically means you want to opt out of Ember's jQuery APIs:

• this.$() in Ember.Component's
• Ember.$
• Ember's jQuery based Event Dispatcher

[rwjblue]

I think this looks good. Would like review from @simonihmig also (likely tomorrow), then can land and release. Thanks for working on it!

[simonihmig]

LGTM, thanks @lupestro! 👍

[simonihmig]

Merged, @rwjblue still needs to release!

[simonihmig]

This seems like a breaking change (i.e. 0.7.0), as an app with integration turned off was still getting the (working) overridden this.$(), while now it will run into Ember's implementation that throws the assertion mentioned above, right?

[rwjblue]

This seems like a breaking change (i.e. 0.7.0), as an app with integration
turned off was still getting the (working) overridden this.$(), while now it will run into Ember's implementation that throws the assertion mentioned above, right?

Agreed, though (as I mentioned above) I think that is correct / intended behavior.