Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 Addon conversion prep: convert to single-package monorepo. #1060

Merged
merged 2 commits into from
Jun 12, 2023
Merged

V2 Addon conversion prep: convert to single-package monorepo. #1060

merged 2 commits into from
Jun 12, 2023

Conversation

NullVoxPopuli
Copy link
Sponsor Collaborator

@NullVoxPopuli NullVoxPopuli commented May 2, 2023 •
edited
Loading

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review May 3, 2023 16:16
This was referenced May 3, 2023
Closed
Merged
Merged
Merged
ijlee2
ijlee2 approved these changes May 4, 2023
View reviewed changes
Copy link
Sponsor Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked that you split code changes into multiple commits, each with a description that explained the reason for the change.

If you fix the typo in the PR title (sigle to single), it may help with the CHANGELOG entry.

@NullVoxPopuli NullVoxPopuli changed the title V2 Addon conversion prep: convert to sigle-package monorepo. V2 Addon conversion prep: convert to single-package monorepo. May 4, 2023
@NullVoxPopuli
Copy link
Sponsor Collaborator Author

updated

This was referenced Jun 1, 2023
Closed
Closed
gilest
gilest approved these changes Jun 4, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@NullVoxPopuli NullVoxPopuli force-pushed the to-monorepo branch 4 times, most recently from 4c3b75b to 8f56157 Compare June 12, 2023 14:53
@NullVoxPopuli
Move addon to subfolder
c3960d9 
Make gitignore work for all directories

Add root package.json

Update CI

Use previously upgraded node
@NullVoxPopuli
Specify working-directory in new push-dist.yml workflow
9e75ef6
@MelSumner
Copy link
Contributor

ok, let's give this a go and see how it works out.

@MelSumner MelSumner merged commit ca61a3c into emberjs:master Jun 12, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilest gilest gilest approved these changes

@ijlee2 ijlee2 ijlee2 approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NullVoxPopuli @MelSumner @gilest @ijlee2