Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test helpers 3 to peers #1068

Closed
wants to merge 2 commits into from

Conversation

NullVoxPopuli
Copy link
Sponsor Collaborator

@NullVoxPopuli NullVoxPopuli commented Jun 1, 2023

This isn't enough to get @ember/test-helpers working.
We need to drop support for node 14 as well, which means, we may as well do a bunch of things that could be breaking, like the v2 conversion, which already drops node 14.

These PRs should be merged/reviewed in order, as they build on each other, so they'll get bigger and bigger unless the prior PRs are merged.

my preference would be to merge those above 4, and ignore this PR until the end (due to conflict resolution concerns)

@NullVoxPopuli
Copy link
Sponsor Collaborator Author

Closing in favor of #1069 (which requires the v2 addon PRs to merged)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant